Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v3] rootfs_ipk: delete opkg metadata if package management not required and all packages are configured
Date: Thu, 02 Jun 2011 17:12:03 -0700	[thread overview]
Message-ID: <4DE826D3.8080108@linux.intel.com> (raw)
In-Reply-To: <1306924871.2529.33.camel@phil-desktop>

On 06/01/2011 03:41 AM, Phil Blundell wrote:
> If all the postinsts were successfully run in offline mode, and
> package-management hasn't been requested as an IMAGE_FEATURE, the opkg
> metadata is now redundant and can safely be deleted.
>
> Also, the update-rc.d and base-passwd packages can be removed since
> they will serve no further purpose in this situation.
>
> If some packages are still unconfigured at this point then we need to
> keep their metadata around so that either opkg or the awk script can
> configure the packages at boot time.  In theory it would be possible to
> strip out the data for packages that have already been configured, but
> right now we just hold on to the whole status file in that situation.
>
> Signed-off-by: Phil Blundell<philb@gnu.org>
> ---
>   meta/classes/rootfs_ipk.bbclass |   11 +++++++++++
>   1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
> index edd84fb..3b4b4da 100644
> --- a/meta/classes/rootfs_ipk.bbclass
> +++ b/meta/classes/rootfs_ipk.bbclass
> @@ -82,6 +82,17 @@ fakeroot rootfs_ipk_do_rootfs () {
>   	
>   	rm -f ${IMAGE_ROOTFS}${opkglibdir}/lists/*
>
> +	if ${@base_contains("IMAGE_FEATURES", "package-management", "false", "true", d)}; then
> +		if [ $runtime_script_required -eq 0 ]; then
> +			# All packages were successfully configured.
> +			# update-rc.d, base-passwd are no further use, remove them now
> +			opkg-cl ${IPKG_ARGS} --force-depends remove update-rc.d base-passwd || true
> +
> +			# Also delete the status files
> +			rm -rf ${IMAGE_ROOTFS}${opkglibdir}
> +		fi
> +	fi
> +
>   	log_check rootfs 	
>   }
>
Merged into oe-core

Thanks
	Sau!



      reply	other threads:[~2011-06-03  0:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-26 11:29 [PATCH] rootfs_ipk: delete opkg metadata if package management not required and all packages are configured Phil Blundell
2011-05-31 11:31 ` [PATCH v2] " Phil Blundell
2011-05-31 17:07   ` Saul Wold
2011-06-01 10:41     ` [PATCH v3] " Phil Blundell
2011-06-03  0:12       ` Saul Wold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DE826D3.8080108@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox