Re: [PATCH] runqemu: take TMPDIR from bitbake

[Scott Garman <scott.a.garman@intel.com>]

On 06/13/2011 10:26 AM, Anders Darander wrote:
> The old standard of using /home/anders/openembedded-core/build/tmp as TMPDIR do not work any longer,
> as - is appended to the real TMPDIR. Thus, always take TMPDIR from
> bitbake, unless TMPDIR is set in the environment.
>
> Signed-off-by: Anders Darander<anders@chargestorm.se>

Thanks for this improvement!

Acked-by: Scott Garman <scott.a.garman@intel.com>

> ---
>   scripts/runqemu |   22 +++++++++-------------
>   1 files changed, 9 insertions(+), 13 deletions(-)
>
> diff --git a/scripts/runqemu b/scripts/runqemu
> index a09362c..aa44070 100755
> --- a/scripts/runqemu
> +++ b/scripts/runqemu
> @@ -262,20 +262,16 @@ SPITZ_DEFAULT_ROOTFS="core-image-sato"
>
>   setup_tmpdir() {
>       if [ -z "$TMPDIR" ]; then
> -        if [ "x$BUILDDIR" = "x" -o ! -d "$BUILDDIR/tmp" ]; then
> -            # BUILDDIR unset, try and get TMPDIR from bitbake
> -            type -P bitbake&>/dev/null || {
> -                echo "In order for this script to dynamically infer paths";
> -                echo "to kernels or filesystem images, you either need";
> -                echo "bitbake in your PATH or to source oe-init-build-env";
> -                echo "before running this script">&2;
> -                exit 1; }
> -
> -            # We have bitbake in PATH, get TMPDIR from bitbake
> -            TMPDIR=`bitbake -e | grep TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2`
> -        else
> -            TMPDIR=$BUILDDIR/tmp
> -        fi
> +        # BUILDDIR unset, try and get TMPDIR from bitbake
> +        type -P bitbake&>/dev/null || {
> +            echo "In order for this script to dynamically infer paths";
> +            echo "to kernels or filesystem images, you either need";
> +            echo "bitbake in your PATH or to source oe-init-build-env";
> +            echo "before running this script">&2;
> +            exit 1; }
> +
> +        # We have bitbake in PATH, get TMPDIR from bitbake
> +        TMPDIR=`bitbake -e | grep TMPDIR=\" | cut -d '=' -f2 | cut -d '"' -f2`
>       fi
>   }
>


-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center