From: Robert Yang <liezhi.yang@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 2/4 V2] Share gcc work directories
Date: Wed, 15 Jun 2011 20:48:43 +0800 [thread overview]
Message-ID: <4DF8AA2B.5010107@windriver.com> (raw)
In-Reply-To: <1308129704.15712.368.camel@rex>
On 06/15/2011 05:21 PM, Richard Purdie wrote:
> Hi Robert,
>
> This is looking good, just one further problem:
>
> On Wed, 2011-06-15 at 14:33 +0800, Robert Yang wrote:
>> * The configure option --with-build-sysroot=${STAGING_DIR_TARGET} can
>> replace the sed command.
>
> Sadly I'm not sure it can.
>
>>
>> EXTRA_OECONF = "${@['--enable-clocale=generic', ''][bb.data.getVar('USE_NLS', d, 1) != 'no']} \
>> --with-gnu-ld \
>> + --with-build-sysroot=${STAGING_DIR_TARGET} \
>> --enable-shared \
>> --enable-languages=${LANGUAGES} \
>> --enable-threads=posix \
>> @@ -88,25 +89,20 @@ do_configure () {
>> (cd ${S}&& gnu-configize) || die "failure running gnu-configize"
>>
>> # teach gcc to find correct target includedir when checking libc ssp support
>> - sed -i 's:^\([ ]*\)glibc_header_dir=\"${with_build_sysroot}/usr/include\":\1glibc_header_dir=\"${with_build_sysroot}${SYSTEMHEADERS}\":g' ${S}/gcc/configure.ac
>> - sed -i 's:^\([ ]*\)glibc_header_dir=\"${with_build_sysroot}/usr/include\":\1glibc_header_dir=\"${with_build_sysroot}${SYSTEMHEADERS}\":g' ${S}/gcc/configure
>
> Here, a hardcoded "/usr/include" in the gcc makefiles is being replaced
> by ${SYSTEMHEADERS} which could be /some/other/path/include. These two
> are therefore not equivalent. Did you try a "bitbake meta-toolchain"
> with this patch series?
>
I'm sorry, because the "bitbake meta-toolchain" didn't work recently(without
these patches), I forgot to build it(just built gcc-cross and gcc-crosssdk),
I will go on working on it and send the V3 later.
Thanks
// Robert
> I suspect configure needs to use ${includedir} to build this path
> instead of hardcoding it.
>
> Cheers,
>
> Richard
>
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
next prev parent reply other threads:[~2011-06-15 12:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-15 6:33 [PATCH 0/4 V2] Share gcc work directories Robert Yang
2011-06-15 6:33 ` [PATCH 1/4 V2] bitbake: share source directory Robert Yang
2011-06-15 6:33 ` [PATCH 2/4 V2] Share gcc work directories Robert Yang
2011-06-15 9:21 ` Richard Purdie
2011-06-15 12:48 ` Robert Yang [this message]
2011-06-15 6:33 ` [PATCH 3/4 V2] gcc-4.5.1: share " Robert Yang
2011-06-15 6:33 ` [PATCH 4/4 V2] gcc-4.6.0: " Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DF8AA2B.5010107@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox