Re: [PATCH RFC] binutils: allow distro to select gold as default cross-linker

[Khem Raj <raj.khem@gmail.com>]

On 06/15/2011 07:32 AM, Phil Blundell wrote:
> On Wed, 2011-06-15 at 09:04 +0100, Phil Blundell wrote:
>> One slightly annoying thing is that (e)glibc isn't buildable with gold
>> because the linker scripts don't work.  So a little bit of patching is
>> going to be needed to have it use ld.bfd there.  There might be some
>> other packages with similar issues but I haven't come across any yet.
>
> I think something like this is probably what's required for that.
>
>  From 48eaba1da89086b8edccaa03c27075d78635ab01 Mon Sep 17 00:00:00 2001
> From: Phil Blundell<philb@gnu.org>
> Date: Wed, 15 Jun 2011 15:22:47 +0100
> Subject: [PATCH] gcc-cross-intermediate: use ld.bfd if distro prefers gold
>
>
> Signed-off-by: Phil Blundell<philb@gnu.org>
> ---
>   .../gcc/gcc-cross-intermediate.inc                 |    7 ++++++-
>   1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-cross-intermediate.inc b/meta/recipes-devtools/gcc/gcc-cross-intermediate.inc
> index 92c3ce2..05b5dbc 100644
> --- a/meta/recipes-devtools/gcc/gcc-cross-intermediate.inc
> +++ b/meta/recipes-devtools/gcc/gcc-cross-intermediate.inc
> @@ -7,6 +7,10 @@ CROSS_TARGET_SYS_DIR_append = ".${PN}"
>
>   # This is intended to be a -very- basic config
>   # sysroot is needed in case we use libc-initial
> +#
> +# Glibc won't compile with gold, and building glibc is the whole point of
> +# this recipe.   So we select ld.bfd explicitly here if gold is the distro's
> +# preferred linker.
>   EXTRA_OECONF = "--with-local-prefix=${STAGING_DIR_TARGET}${target_prefix} \
>   		--enable-shared \
>   		--disable-multilib \
> @@ -17,7 +21,8 @@ EXTRA_OECONF = "--with-local-prefix=${STAGING_DIR_TARGET}${target_prefix} \
>   		--with-sysroot=${STAGING_DIR_TCBOOTSTRAP} \
>   		--with-build-sysroot=${STAGING_DIR_TCBOOTSTRAP} \
>   		${EXTRA_OECONF_INTERMEDIATE} \
> -		${@get_gcc_fpu_setting(bb, d)}"
> +		${@get_gcc_fpu_setting(bb, d)} \
> +		${@base_contains('DISTRO_FEATURES', 'ld-is-gold', '--with-ld=${STAGING_BINDIR_TOOLCHAIN}/${TARGET_PREFIX}ld.bfd', '', d)}"
>
>   do_populate_sysroot[sstate-inputdirs] = "${SYSROOT_DESTDIR}/${STAGING_DIR_HOST} ${SYSROOT_DESTDIR}/${STAGING_DIR_TARGET}/${target_base_libdir}"
>   do_populate_sysroot[sstate-outputdirs] = "${STAGING_DIR_HOST} ${STAGING_DIR_TCBOOTSTRAP}/${target_base_libdir}"

this might not work second time around when gcc-cross has been staged.