From: Khem Raj <raj.khem@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/6] connman: Upgrade to version 0.75
Date: Thu, 16 Jun 2011 06:44:02 -0700 [thread overview]
Message-ID: <4DFA08A2.3010504@gmail.com> (raw)
In-Reply-To: <1308216925.25285.4101.camel@phil-desktop>
On 6/16/2011 2:35 AM, Phil Blundell wrote:
> On Thu, 2011-06-16 at 17:20 +0800, Dongxiao Xu wrote:
>> Enable ofono plugin into sato image.
>
> [...]
>
>> --- a/meta/recipes-connectivity/connman/connman.inc
>> +++ b/meta/recipes-connectivity/connman/connman.inc
>> @@ -14,7 +14,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>> file://src/main.c;beginline=1;endline=20;md5=4b55b550fa6b33cc2055ef30dd262b3e"
>>
>> DEPENDS = "libgdbus dbus glib-2.0 hal iptables"
>> -RDEPENDS_${PN} = "wpa-supplicant resolvconf"
>> +RDEPENDS_${PN} = "wpa-supplicant resolvconf ofono"
>
>> --- a/meta/recipes-connectivity/connman/connman_0.65.bb
>> +++ b/meta/recipes-connectivity/connman/connman_0.75.bb
>> @@ -16,14 +16,14 @@ EXTRA_OECONF += "\
>> --disable-udev \
>> --disable-polkit \
>> --enable-client \
>> + --enable-ofono \
>> --prefix=/usr --sysconfdir=/etc --localstatedir=/var"
>
> These changes look like they will have a rather wider impact than just
> the sato image. I'm not sufficiently au fait with connman to say
> whether this is a good thing or not (although my immediate reaction to
> adding extra RDEPENDS tends to be that it is not), but if they're going
> to be added globally then the checkin comment ought to reflect that and
> explain why it's being done. Alternatively, you could do this in your
> distro layer and/or image recipes.
>
I would say put ofono as a DISTRO_FEATURE
> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2011-06-16 13:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-16 9:20 [PATCH 0/6 v2][PULL] 3G network support in Yocto Dongxiao Xu
2011-06-16 9:20 ` [PATCH 1/6] connman: Upgrade to version 0.75 Dongxiao Xu
2011-06-16 9:35 ` Phil Blundell
2011-06-16 10:36 ` Paul Eggleton
2011-06-16 10:55 ` Koen Kooi
2011-06-16 13:44 ` Khem Raj [this message]
2011-06-16 13:52 ` Phil Blundell
2011-06-16 14:00 ` Koen Kooi
2011-06-16 23:12 ` Khem Raj
2011-06-17 7:08 ` Xu, Dongxiao
2011-06-17 7:15 ` Koen Kooi
2011-06-21 1:36 ` Xu, Dongxiao
2011-06-16 9:42 ` Koen Kooi
2011-06-16 9:20 ` [PATCH 2/6] wpa-supplicant: remove the 0.6.10 version Dongxiao Xu
2011-06-16 9:20 ` [PATCH 3/6] ofono: add 0.42 version which works OK for Ericsson 3G module Dongxiao Xu
2011-06-16 9:20 ` [PATCH 4/6] connman-gnome: Add 3G configuration support Dongxiao Xu
2011-06-16 9:30 ` Koen Kooi
2011-06-17 0:27 ` Xu, Dongxiao
2011-06-16 9:20 ` [PATCH 5/6] systemtap: add fishriver in COMPATIBLE_MACHINE Dongxiao Xu
2011-06-16 14:11 ` Tom Zanussi
2011-06-17 1:41 ` Xu, Dongxiao
2011-06-16 9:20 ` [PATCH 6/6] initscript: Change some order of init scripts Dongxiao Xu
2011-06-16 9:38 ` Andrea Adami
2011-06-16 9:41 ` Phil Blundell
2011-06-17 1:39 ` Xu, Dongxiao
-- strict thread matches above, loose matches on Subject: below --
2011-06-29 2:59 [PATCH 0/6 v4][PULL] 3G network support Dongxiao Xu
2011-06-29 2:59 ` [PATCH 1/6] connman: Upgrade to version 0.75 Dongxiao Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFA08A2.3010504@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox