Re: [PATCH 1/1] base-passwd: disable problematic login.defs options

[Scott Garman <scott.a.garman@intel.com>]

On 06/16/2011 04:54 PM, Khem Raj wrote:
> On 06/16/2011 11:50 AM, Scott Garman wrote:
>> This resolves the following runtime errors when various shadow-utils
>> binaries are run:
>>
>> configuration error - unknown item 'FAILLOG_ENAB' (notify administrator)
>> configuration error - unknown item 'LASTLOG_ENAB' (notify administrator)
>> configuration error - unknown item 'OBSCURE_CHECKS_ENAB' (notify
>> administrator)
>> configuration error - unknown item 'PORTTIME_CHECKS_ENAB' (notify
>> administrator)
>> configuration error - unknown item 'QUOTAS_ENAB' (notify administrator)
>> configuration error - unknown item 'MOTD_FILE' (notify administrator)
>> configuration error - unknown item 'FTMP_FILE' (notify administrator)
>> configuration error - unknown item 'NOLOGINS_FILE' (notify administrator)
>> configuration error - unknown item 'ENV_HZ' (notify administrator)
>> configuration error - unknown item 'PASS_MIN_LEN' (notify administrator)
>> configuration error - unknown item 'SU_WHEEL_ONLY' (notify administrator)
>> configuration error - unknown item 'CRACKLIB_DICTPATH' (notify
>> administrator)
>> configuration error - unknown item 'PASS_CHANGE_TRIES' (notify
>> administrator)
>> configuration error - unknown item 'PASS_ALWAYS_WARN' (notify
>> administrator)
>> configuration error - unknown item 'CHFN_AUTH' (notify administrator)
>> configuration error - unknown item 'ENVIRON_FILE' (notify administrator)
>>
>> This fixes bug [YOCTO #1170]
>>
>> Signed-off-by: Scott Garman<scott.a.garman@intel.com>
>> ---
>> .../base-passwd/base-passwd-3.5.22/login.defs | 32 ++++++++++----------
>> .../recipes-core/base-passwd/base-passwd_3.5.22.bb | 2 +-
>> 2 files changed, 17 insertions(+), 17 deletions(-)
>>
>> diff --git
>> a/meta/recipes-core/base-passwd/base-passwd-3.5.22/login.defs
>> b/meta/recipes-core/base-passwd/base-passwd-3.5.22/login.defs
>> index 1d392ac..2708eb6 100644
>> --- a/meta/recipes-core/base-passwd/base-passwd-3.5.22/login.defs
>> +++ b/meta/recipes-core/base-passwd/base-passwd-3.5.22/login.defs
>
> I wonder if login.defs should be provided at all by base-passwd package.
> It should come from shadow isnt it ?

Hi Khem,

The reason for including the login.defs file with base-passwd has to do 
with the new useradd.bbclass that I developed (Richard is still holding 
it for code review, but we should see it here soon). The way it works is 
custom users/groups get added to the passwd/group files in the target 
machine's sysroot. The shadow utils require a login.defs in order to 
work. Thus, a default login.defs needs to be shipped with base-passwd now.

As a side note, my first iteration on this design used a 
base-passwd-cross recipe instead. Richard suggested that maintaining a 
separate -cross recipe was not necessary, and to integrate the target 
sysroot changes into the base-passwd recipe (given that otherwise there 
were no meaningful differences).

If anyone feels strongly about this, now would be the time to make your 
case.

Scott

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center