Re: [PATCH 2/2] sanity: implement network connectivity test

[Khem Raj <raj.khem@gmail.com>]

On 6/25/2011 5:53 PM, Saul Wold wrote:
> On 06/20/2011 11:09 AM, Joshua Lock wrote:
>> Sanity test to verify files can be fetched from the network using git,
>> http
>> and https fetchers point users at a page to help get set up in the
>> case of a
>> failure.
>>
>> Addresses [YOCTO #933]
>>
>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>> ---
>> meta/classes/sanity.bbclass | 34 ++++++++++++++++++++++++++++++++++
>> 1 files changed, 34 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
>> index bffa4f5..650df5f 100644
>> --- a/meta/classes/sanity.bbclass
>> +++ b/meta/classes/sanity.bbclass
>> @@ -35,6 +35,8 @@ def check_sanity_tmpdir_change(tmpdir, data):
>>
>> # Check that TMPDIR isn't on a filesystem with limited filename length
>> (eg. eCryptFS)
>> testmsg = check_create_long_filename(tmpdir, "TMPDIR")
>> + # Check that we can fetch from various network transports
>> + testmsg = testmsg + check_connectivity(data)
>> return testmsg
>>
>> def check_sanity_version_change(data):
>> @@ -75,6 +77,38 @@ def check_create_long_filename(filepath, pathname):
>> return "Failed to create a file in %s: %s" % (pathname, strerror)
>> return ""
>>
>> +def check_connectivity(d):
>> + # URI's to check can be set in the CONNECTIVITY_CHECK_URIS variable
>> using
>> + # the same syntax as SRC_URI.
>> + test_uris = (bb.data.getVar('CONNECTIVITY_CHECK_URIS', d, True) or
>> "").split()
>> + # If no URI's set, fallback to some default ones we know of
>> + if len(test_uris) == 0:
>> + test_uris = ["http://yoctoproject.org/about",
>> +
>> "https://eula-downloads.yoctoproject.org/crownbay/crownbay-bernard-5.0.0",
>>
>> + "git://git.yoctoproject.org/yocto-firewall-test;protocol=git;rev=HEAD"]
>> + retval = ""

imo this change is yocto specific doesnt belong to core
>> +
>> + # Only check connectivity if network access and this check enabled.
>> + # Because it's a fairly heavy test allow disabling of just this
>> sanity test
>> + # by setting DISABLE_NETWORK_SANITY.
>> + network_disabled = not bb.data.getVar('BB_NO_NETWORK', d, True)
>> + check_disabled = bb.data.getVar('DISABLE_NETWORK_SANITY', d, True)
>> + if check_disabled or network_disabled:
>> + data = bb.data.createCopy(d)
>> + dldir = bb.data.expand('${TMPDIR}/sanity', data)
>> + bb.data.setVar('DL_DIR', dldir, data)
>> +
>> + try:
>> + fetcher = bb.fetch2.Fetch(test_uris, data)
>> + fetcher.download()
>> + fetcher.clean(test_uris)
>> + except Exception:
>> + retval = "Error connecting to the network to fetch, http/https and
>> git checked.\nPlease check the wiki
>> (https://wiki.yoctoproject.org/wiki/Connectivity\%20Troubleshooting)
>> for more suggestions.\n"
>> + finally:
>> + # Make sure we tidy up the cruft
>> + oe.path.remove(dldir)
>> + return retval
>> +
>> def check_sanity(e):
>> from bb import note, error, data, __version__
>>
>
> Josh,
>
> When I ran this, I got the following messages about missing SRC_URI
> Checksums and then it failed to parse recipes. When I removed this
> commit things worked normally.
>
>
>
> Pseudo is not present but is required, building this first before the
> main build
> Cloning into bare repository
> /intel/poky2/builds/pending/tmp/sanity/git2/git.yoctoproject.org.yocto-firewall-test...
>
> NOTE: fetch http://yoctoproject.org/about
> WARNING: Missing SRC_URI checksum for
> /intel/poky2/builds/pending/tmp/sanity/about, consider adding to the
> recipe:
> SRC_URI[md5sum] = "1ca6c9ee2ce5dc5d251e649cbd4e339f"
> SRC_URI[sha256sum] =
> "24cda768cacaf6cc41ab75a46df4936f58075c4788e094c262c35d5ba69544e2"
> NOTE: fetch
> https://eula-downloads.yoctoproject.org/crownbay/crownbay-bernard-5.0.0
> WARNING: Missing SRC_URI checksum for
> /intel/poky2/builds/pending/tmp/sanity/crownbay-bernard-5.0.0, consider
> adding to the recipe:
> SRC_URI[md5sum] = "c534ba257c640e47300572607762b22a"
> SRC_URI[sha256sum] =
> "485812cf1c43381d70611e85eaf8a74982b452121bdc92accf7a62f0a2707137"
> NOTE: fetch
> http://autobuilder.yoctoproject.org/sources/git2_git.yoctoproject.org.yocto-firewall-test.tar.gz
>
> Parsing recipes...ERROR: Command execution failed: Exited with 1
> NOTE: fetch
> http://autobuilder.yoctoproject.org/sources/git2_git.yoctoproject.org.yocto-firewall-test.tar.gz
>
> WARNING: Missing SRC_URI checksum for
> /intel/poky2/builds/pending/tmp/sanity/crownbay-bernard-5.0.0, consider
> adding to the recipe:
> SRC_URI[md5sum] = "c534ba257c640e47300572607762b22a"
> SRC_URI[sha256sum] =
> "485812cf1c43381d70611e85eaf8a74982b452121bdc92accf7a62f0a2707137"
> NOTE: fetch
> https://eula-downloads.yoctoproject.org/crownbay/crownbay-bernard-5.0.0
> WARNING: Missing SRC_URI checksum for
> /intel/poky2/builds/pending/tmp/sanity/about, consider adding to the
> recipe:
> SRC_URI[md5sum] = "1ca6c9ee2ce5dc5d251e649cbd4e339f"
> SRC_URI[sha256sum] =
> "24cda768cacaf6cc41ab75a46df4936f58075c4788e094c262c35d5ba69544e2"
> NOTE: fetch http://yoctoproject.org/about
>
> Thanks
> Sau!
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core