Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: Patches and discussions about the oe-core layer
	<public-openembedded-core-ZwoEplunGu3dfDuKDZ/zN51Ccm5ICvs9@plane.gmane.org>
Cc: Anders Darander <public-anders-7UjN0b3lYz2SbKU13Z4Etw@plane.gmane.org>
Subject: Re: [RFC v2 PATCH 1/9] Remove support for building 2.4 kernels
Date: Tue, 28 Jun 2011 14:56:36 +0100	[thread overview]
Message-ID: <4E09DD94.60004@cam.ac.uk> (raw)
In-Reply-To: <19f9cd53099a185415ba765f70f8d9982ce0675a.1309203545.git.anders@chargestorm.se>



Hi Anders,

All seems to work for me.  For anyone just dropping these on OE, note there is
a local variable of kernel.bbclass that also needs updating as per this file
in meta-openembedded/meta-oe/

> Signed-off-by: Anders Darander <anders-7UjN0b3lYz2SbKU13Z4Etw@public.gmane.org>
> ---
>  meta/classes/kernel.bbclass      |   12 ++----------
>  meta/classes/module-base.bbclass |    2 +-
>  2 files changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index fd27832..6bdfd3e 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -73,9 +73,6 @@ KERNEL_ALT_IMAGETYPE ??= ""
>  kernel_do_compile() {
>  	unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
>  	oe_runmake include/linux/version.h CC="${KERNEL_CC}" LD="${KERNEL_LD}"
> -	if [ "${KERNEL_MAJOR_VERSION}" != "2.6" ]; then
> -		oe_runmake dep CC="${KERNEL_CC}" LD="${KERNEL_LD}"
> -	fi
>  	oe_runmake ${KERNEL_IMAGETYPE} ${KERNEL_ALT_IMAGETYPE} CC="${KERNEL_CC}" LD="${KERNEL_LD}"
>  }
>  
> @@ -111,9 +108,7 @@ kernel_do_install() {
>  	install -m 0644 vmlinux ${D}/boot/vmlinux-${KERNEL_VERSION}
>  	[ -e Module.symvers ] && install -m 0644 Module.symvers ${D}/boot/Module.symvers-${KERNEL_VERSION}
>  	install -d ${D}/etc/modutils
> -	if [ "${KERNEL_MAJOR_VERSION}" = "2.6" ]; then
> -		install -d ${D}/etc/modprobe.d
> -	fi
> +	install -d ${D}/etc/modprobe.d
>  
>  	#
>  	# Support for external module building - create a minimal copy of the
> @@ -397,10 +392,7 @@ python populate_packages_prepend () {
>  		# Write out any modconf fragment
>  		modconf = bb.data.getVar('module_conf_%s' % basename, d, 1)
>  		if modconf:
> -			if bb.data.getVar("KERNEL_MAJOR_VERSION", d, 1) == "2.6":
> -				name = '%s/etc/modprobe.d/%s.conf' % (dvar, basename)
> -			else:
> -				name = '%s/etc/modutils/%s.conf' % (dvar, basename)
> +			name = '%s/etc/modprobe.d/%s.conf' % (dvar, basename)
>  			f = open(name, 'w')
>  			f.write("%s\n" % modconf)
>  			f.close()
> diff --git a/meta/classes/module-base.bbclass b/meta/classes/module-base.bbclass
> index c98bace..a7cf233 100644
> --- a/meta/classes/module-base.bbclass
> +++ b/meta/classes/module-base.bbclass
> @@ -7,7 +7,7 @@ export CROSS_COMPILE = "${TARGET_PREFIX}"
>  
>  export KERNEL_VERSION = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion')}"
>  export KERNEL_SOURCE = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-source')}"
> -KERNEL_OBJECT_SUFFIX = "${@[".o", ".ko"][base_read_file('${STAGING_KERNEL_DIR}/kernel-abiversion') > "2.6.0"]}"
> +KERNEL_OBJECT_SUFFIX = ".ko"
>  KERNEL_CCSUFFIX = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-ccsuffix')}"
>  KERNEL_LDSUFFIX = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-ldsuffix')}"
>  KERNEL_ARSUFFIX = "${@base_read_file('${STAGING_KERNEL_DIR}/kernel-arsuffix')}"





  reply	other threads:[~2011-06-28 14:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-27 19:39 [RFC v2 PATCH 0/9] Linux 3.0 build support Anders Darander
2011-06-27 19:40 ` [RFC v2 PATCH 1/9] Remove support for building 2.4 kernels Anders Darander
2011-06-28 13:56   ` Jonathan Cameron [this message]
2011-06-27 19:40 ` [RFC v2 PATCH 2/9] image¡kernel.bblass: do not use depmod-2.6 Anders Darander
2011-06-27 19:40 ` [RFC v2 PATCH 3/9] modules-init-tools(-cross): update to 3.16 Anders Darander
2011-06-27 19:40 ` [RFC v2 PATCH 4/9] module-init-tools-cross: do not install depmod as depmod-2.6 Anders Darander
2011-06-27 19:40 ` [RFC v2 PATCH 5/9] kernel.bblass: remove get_kernelmajorversion Anders Darander
2011-06-27 19:40 ` [RFC v2 PATCH 6/9] modutils-initscripts: move recipe prior to modutils removal Anders Darander
2011-06-27 19:40 ` [RFC v2 PATCH 7/9] modutils: remove modutils Anders Darander
2011-06-27 19:40 ` [RFC v2 PATCH 8/9] task-base: remove modutils reference Anders Darander
2011-06-27 19:40 ` [RFC v2 PATCH 9/9] distro_tracking_fields: remove modutils Anders Darander
2011-06-28 14:27 ` [RFC v2 PATCH 0/9] Linux 3.0 build support Bruce Ashfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E09DD94.60004@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=public-anders-7UjN0b3lYz2SbKU13Z4Etw@plane.gmane.org \
    --cc=public-openembedded-core-ZwoEplunGu3dfDuKDZ/zN51Ccm5ICvs9@plane.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox