Re: [PATCH] eglibc-locale: fix localedef packaging

[Saul Wold <sgw@linux.intel.com>]

On 06/30/2011 07:54 AM, Richard Purdie wrote:
> On Thu, 2011-06-30 at 12:17 +0100, Phil Blundell wrote:
>> On Wed, 2011-06-29 at 14:49 +0100, Richard Purdie wrote:
>>> I'd love to see a patch for this! :)
>>
>> Your wish, naturally, is my command.  I've built micro-base-image with
>> this and verified that I didn't get any false positives; I also checked
>> (via some manual fiddling) that it did indeed detect the case that we
>> want it to.
>>
>> I guess it might be a good idea for someone to test it with a slightly
>> larger dataset before actually checking it in, just in case.
>
> Thanks, I'll let Saul try this against a wider build and assuming it
> doesn't throw out too many issues we can get it merged.
>
Phil,

Can I get this as a proper patch email with a clean header, I will start 
testing with below.

Thanks
	Sau!


> Cheers,
>
> Richard
>
>> p.
>>
>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>> index 35809b9..f7e5524 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -103,6 +103,7 @@ def package_qa_get_machine_dict():
>>   # 8 - .la contains reference to the workdir
>>   # 9 - LDFLAGS ignored
>>   # 10 - Build paths in binaries
>> +# 11 - package depends on devel package
>>
>>   def package_qa_clean_path(path,d):
>>       """ Remove the common prefix from the path. In this case it is the TMPDIR"""
>> @@ -134,6 +135,7 @@ def package_qa_write_error(error_class, name, path, d):
>>           ".la contains reference to the workdir",
>>           "LDFLAGS ignored",
>>           "package contains reference to tmpdir paths",
>> +	"package depends on devel package",
>>       ]
>>
>>       log_path = os.path.join( bb.data.getVar('T', d, True), "log.qa_package" )
>> @@ -493,12 +495,14 @@ def package_qa_check_rdepends(pkg, pkgdest, d):
>>           # Now check the RDEPENDS
>>           rdepends = bb.utils.explode_deps(bb.data.getVar('RDEPENDS', localdata, True) or "")
>>
>> -
>>           # Now do the sanity check!!!
>>           for rdepend in rdepends:
>>               if "-dbg" in rdepend:
>>                   error_msg = "%s rdepends on %s" % (pkgname,rdepend)
>>                   sane = package_qa_handle_error(2, error_msg, pkgname, rdepend, d)
>> +	    if (not "-dev" in pkg and not "-staticdev" in pkg) and rdepend.endswith("-dev"):
>> +	        error_msg = "%s rdepends on %s" % (pkgname, rdepend)
>> +                sane = package_qa_handle_error(11, error_msg, pkgname, rdepend, d)
>>
>>       return sane
>>
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>