Re: [PATCH] insane bbclass: turn fatal errors back into fatal errors

[Mark Hatle <mark.hatle@windriver.com>]

On 6/30/11 10:58 AM, Tom Rini wrote:
> On 06/30/2011 08:11 AM, Koen Kooi wrote:
>> These were turned off by:
>>
>> 	commit fae8d5e985e9b05ce90f1eca434ad4dbf2259725
>> 	Author: Richard Purdie <rpurdie@linux.intel.com>
>> 	Date:   Thu Jul 8 23:51:06 2010 +0100
>>
>> 		insane.bbclass: Relax fatal errors for now until we get have time to work through the backlog
>>
>> The current metadata triggers so many of these that they need to be made fatal so people will actually fix them.
>>
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> 
> Given that a number of them can probably just be pulled from oe.dev as
> fixes too:
> 
> Acked-by: Tom Rini <tom_rini@mentor.com>

I'm really worried about the current warnings/QA issues that keep coming up.. so
I agree we really need to do this.. (note, we also really need to tell people to
expect some breakage as we go and fix the mess!)

Acked-by: Mark Hatle <mark.hatle@windriver.com>

>> ---
>>  meta/classes/insane.bbclass |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
>> index f7e5524..e06d2b2 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -115,7 +115,6 @@ def package_qa_make_fatal_error(error_class, name, path,d):
>>  
>>      TODO: Load a whitelist of known errors
>>      """
>> -    return False
>>      return not error_class in [0, 5, 7, 8, 9]
>>  
>>  def package_qa_write_error(error_class, name, path, d):
> 
>