Re: [PATCH 1/2] kernel.bbclass: handle embedding of initramfs images

[Darren Hart <dvhart@linux.intel.com>]

On 07/07/2011 04:11 PM, Andrea Adami wrote:
> * from org.openembedded.dev (oe-classic)

Hi Andrea,

Please include a descriptive blurb about the patch. When people read
through the commit log they need to know what problem this patch
addresses and how it intends to go about it. If possible, it should also
include the commit id from the source (I suspect that isn't an option here).


> +INITRAMFS_IMAGE ?= ""
> +INITRAMFS_TASK ?= ""
> +
>  inherit kernel-arch deploy
>  
>  PACKAGES_DYNAMIC += "kernel-module-*"
> @@ -179,8 +191,18 @@ kernel_do_configure() {
>  		cp "${WORKDIR}/defconfig" "${S}/.config"
>  	fi
>          yes '' | oe_runmake oldconfig
> +
> +	if [ ! -z "${INITRAMFS_IMAGE}" ]; then
> +		for img in cpio.gz cpio.lzo cpio.lzma; do
> +		if [ -e "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE}-${MACHINE}.$img"
> +			cp "${DEPLOY_DIR_IMAGE}/${INITRAMFS_IMAGE}-${MACHINE}.$i
> +		fi
> +		done
> +	fi


Hrm... Why is this part of do_configure? Seems a lot more like a deploy
or install step. Also, the cp line has been truncated here.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel