Re: [PATCH 1/2] classes/image_types: add a variable to list available IMAGE_FSTYPE's

[Gary Thomas <gary@mlbassoc.com>]

On 07/12/2011 05:38 PM, Tom Rini wrote:
> On 07/12/2011 04:24 PM, Joshua Lock wrote:
>> This is for use in the Hob GUI to enable the user to change the type of the
>> generated image.
>>
>> Signed-off-by: Joshua Lock<josh@linux.intel.com>
>> ---
>>   meta/classes/image_types.bbclass |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
>> index 89a745c..29d7a57 100644
>> --- a/meta/classes/image_types.bbclass
>> +++ b/meta/classes/image_types.bbclass
>> @@ -102,3 +102,5 @@ IMAGE_DEPENDS_cpio.xz = "xz-native"
>>   IMAGE_DEPENDS_ubi = "mtd-utils-native"
>>   IMAGE_DEPENDS_ubifs = "mtd-utils-native"
>>
>> +# This variable is available to request which values are suitable for IMAGE_FSTYPES
>> +IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz squashfs squashfs-lzma ubi ubifs"
>
> Concept is fine, but please don't list ubi and ubifs just list ubi.

Perhaps the [brokwn] rule to explicitly build ubifs should also be purged?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------