From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-iw0-f175.google.com ([209.85.214.175]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QjaLL-0005qi-Rq for openembedded-core@lists.openembedded.org; Wed, 20 Jul 2011 19:14:48 +0200 Received: by iwn4 with SMTP id 4so375396iwn.6 for ; Wed, 20 Jul 2011 10:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=w4ojDtjFBQh+QkBES6cGwkVUfPidMgb+1ni3hki0f+c=; b=H2lbA4Qs3fb2HHd9B/mAm0s4CR1aJ7uccjfV6jox6QdkszGDTbJjr3O+/akbRpoMcO fm89c82Xiy9sje2gSlrUnxg0mm57SnG2So1jQOSpqFbMu5fLoL1HCwiUbXbqh/Vn7t+k ZBYf3WiroAueNTIlu2dnnCnqiEUbbonJZVTKo= Received: by 10.231.207.71 with SMTP id fx7mr7873384ibb.168.1311181715228; Wed, 20 Jul 2011 10:08:35 -0700 (PDT) Received: from [172.23.10.146] (natint3.juniper.net [66.129.224.36]) by mx.google.com with ESMTPS id c2sm269693ibd.56.2011.07.20.10.08.33 (version=SSLv3 cipher=OTHER); Wed, 20 Jul 2011 10:08:34 -0700 (PDT) Message-ID: <4E270B8F.3050203@gmail.com> Date: Wed, 20 Jul 2011 10:08:31 -0700 From: Khem Raj User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: openembedded-core@lists.openembedded.org References: <281DBDA2-688D-4559-8191-276A44DEDF70@dominion.thruhere.net> <4E245054.4000303@windriver.com> <4E245163.4000809@windriver.com> In-Reply-To: Subject: Re: [PATCH 3/4] udev: Change hard coded /usr/lib to support multilib X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2011 17:14:48 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 07/18/2011 05:30 PM, Xu, Dongxiao wrote: >> -----Original Message----- >> From: openembedded-core-bounces@lists.openembedded.org >> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of >> Mark Hatle >> Sent: Monday, July 18, 2011 11:30 PM >> To: openembedded-core@lists.openembedded.org >> Subject: Re: [OE-core] [PATCH 3/4] udev: Change hard coded /usr/lib to support >> multilib >> >> Replying to myself.. sorry, I misunderstood the concern.. see below for a new >> explanation.. >> >> On 7/18/11 10:25 AM, Mark Hatle wrote: >>> On 7/18/11 7:32 AM, Koen Kooi wrote: >>>> >>>> Op 18 jul 2011, om 09:08 heeft Koen Kooi het volgende geschreven: >>>> >>>>> >>>>> Op 18 jul 2011, om 08:13 heeft Dongxiao Xu het volgende geschreven: >>>>> >>>>>> Signed-off-by: Dongxiao Xu >>>>>> --- >>>>>> meta/recipes-core/udev/udev-164/makefile.patch | 16 >> ++++++++++++++++ >>>>>> meta/recipes-core/udev/udev-new.inc | 1 + >>>>>> meta/recipes-core/udev/udev_164.bb | 2 +- >>>>>> 3 files changed, 18 insertions(+), 1 deletions(-) create mode >>>>>> 100644 meta/recipes-core/udev/udev-164/makefile.patch >>>>>> >>>>>> diff --git a/meta/recipes-core/udev/udev-164/makefile.patch >>>>>> b/meta/recipes-core/udev/udev-164/makefile.patch >>>>>> new file mode 100644 >>>>>> index 0000000..c46ff4b >>>>>> --- /dev/null >>>>>> +++ b/meta/recipes-core/udev/udev-164/makefile.patch >>>>>> @@ -0,0 +1,16 @@ >>>>>> +Upstream-Status: Inappropriate [configuration] >>>>> >>>>> Could you explain why it's inappropriate for upstream but why we do need it >> here? >>>> >>>> I asked the udev maintainer: >>>> >>>> 14:25< koen> kay: the udev Makefile.am has 'ln -sf $(libexecdir)/udev-acl >> $(DESTDIR)$(prefix)/lib/ConsoleKit/run-seat.d/udev-acl.ck', any reason for not >> using ${libdir} over ${prefix}/lib ? >>>> 14:29< kay> koen: libdir is /usr/lib64 here, can't use that >>>> >>>> So upstream is aware of multilib, but wants to put these scripts in a >> non-multilib dir. Since I don't have any experience with the fedora/opensuse >> way of multilib nor the new oe-core one, could you please explain why oe-core >> needs this patch, but fedora/opensuse don't? >>> >>> This is likely a problem with the multilib fix. "libexecdir" is often >>> /usr/lib on many distribuions.. however as your other email >>> mentioned.. setting it to >>> /usr/lib64 is a mistake. It should be /usr/libexec or /usr/lib64. >>> All of the associated multilib packages should work correctly and no >>> conflicts introduced with this package (file contents should be >>> identical.) >>> >>> It should be permissible for libexecdir to be changed in the >>> configuration if someone really wants it to be. By default (in bitbake.conf) it >> is: >>> >>> export libexecdir = "${exec_prefix}/libexec" >> >>> +- mkdir -p $(DESTDIR)$(prefix)/lib/ConsoleKit/run-seat.d >>> +- ln -sf $(libexecdir)/udev-acl >> $(DESTDIR)$(prefix)/lib/ConsoleKit/run-seat.d/udev-acl.ck >>> ++ mkdir -p $(DESTDIR)$(libdir)/ConsoleKit/run-seat.d >>> ++ ln -sf $(libexecdir)/udev-acl >>> ++$(DESTDIR)$(libdir)/ConsoleKit/run-seat.d/udev-acl.ck >> >> I see libexecdir CAN be changed.. so the above is already possible.. >> >> The part they had hard coded is "/usr/lib/ConsoleKit"... There is only one >> location in the system for ConsoleKit configuration files/scripts.. and that is >> distro specific. Assuming the oe based distributions use >> $(PREFIX)/lib/ConsoleKit.. then the previous was correct. >> >> The point being it doesn't matter if it's 32-bit, 64-bit or 24-bit... only one >> ConsoleKit per system should exist. (There are potentially other files on the >> system like this. I know a recent RPM patch went in that separated >> /usr/lib/rpm and /usr/lib64/rpm.. this is also a similar mistake, I just haven't >> had time to get a patch out to revert that chunk.) > > So for multilib system, we have /usr/lib32 and /usr/lib64 to contain only *.so files, while there is still /usr/lib directory which contains other types of files, right? in ideal world /usr/lib could just be a symlink to default multilib