From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay1.mentorg.com ([192.94.38.131]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QkKJe-000267-1u for openembedded-core@lists.openembedded.org; Fri, 22 Jul 2011 20:19:14 +0200 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1QkKFd-0001Bg-Ro from Tom_Rini@mentor.com for openembedded-core@lists.openembedded.org; Fri, 22 Jul 2011 11:15:05 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Fri, 22 Jul 2011 11:12:41 -0700 Received: from [172.30.80.68] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Fri, 22 Jul 2011 11:15:05 -0700 Message-ID: <4E29BE22.5060002@mentor.com> Date: Fri, 22 Jul 2011 11:14:58 -0700 From: Tom Rini Organization: Mentor Graphics Corporation User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: References: <1311357628.2344.153.camel@rex> In-Reply-To: <1311357628.2344.153.camel@rex> X-Enigmail-Version: 1.1.1 X-OriginalArrivalTime: 22 Jul 2011 18:12:41.0858 (UTC) FILETIME=[F28FDE20:01CC489A] Subject: Re: [PATCH 5/3] conf/machine/include: Start to fill out architecture specific tune include files and tune features X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2011 18:19:14 -0000 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 07/22/2011 11:00 AM, Richard Purdie wrote: > These changes revolve around the idea of tune features. These are represented by > 'flag' strings that are included in the TUNE_FEATURES variable. > > Any string included in TUNE_FEATURES should also add a TUNEVALID[] entry so > we can know which flags are available in TUNE_FEATURES and have documentation about > what the flags do. We will add sanity code to error if flags are listed in > TUNE_FEATURES but are not documented in TUNEVALID. > > A given tune configuration will want to define one or more predetermined sets of > _FEATURE flag lists. These are defined in the form TUNE_FEATURES_tune-. > For defined tune configuation, should be added to the AVAILTUNE list so that > we can determine what tune configurations are available. Flags cannot be used in this > case as with TUNEVALID since its useful to be able to build up tune lists from other > TUNE_FEATURES_tune-yyy options. > > A given tune configuration may also define PACKAGE_EXTRA_ARCHS_tune- and > BASE_LIB_tune- to control the multilib location. All options can be overridden > by the distro or local user configuration. > > Signed-off-by: Richard Purdie As a specific nit, we can't use x86_64 in OVERRIDES (using the normal mechanism need base_contains(...). Can we switch to calling it amd64 ala Debian/Ubuntu? Aside from that, as I told Mark the other day, this looks good to me. -- Tom Rini Mentor Graphics Corporation