Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/3] openjade-native: Add SYSROOT_PREPROCESS_FUNC
Date: Fri, 22 Jul 2011 20:25:22 -0700	[thread overview]
Message-ID: <4E2A3F22.8000007@linux.intel.com> (raw)
In-Reply-To: <1311379036.8710.1.camel@scimitar>

On 07/22/2011 04:57 PM, Joshua Lock wrote:
> On Fri, 2011-07-22 at 16:54 -0700, Saul Wold wrote:
>> [YOCTO #1250]
>>
>> This added function will install a private install-catalog binary so that shared state
>> can find the binary as there is not a guarantee.
>>
>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>> ---
>>   .../openjade/openjade-native_1.3.2.bb              |   12 ++++++++++--
>>   1 files changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
>> index 1c672e1..3922968 100644
>> --- a/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
>> +++ b/meta/recipes-devtools/openjade/openjade-native_1.3.2.bb
>> @@ -7,7 +7,7 @@ SECTION = "base"
>>   LICENSE = "BSD"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=641ff1e4511f0a87044ad42f87cb1045"
>>
>> -PR = "r2"
>> +PR = "r3"
>>
>>   DEPENDS = "opensp-native sgml-common-native"
>>   RDEPENDS_${PN} = "sgml-common"
>> @@ -31,6 +31,8 @@ CONFIGUREOPTS := "${@d.getVar('CONFIGUREOPTS', True).replace('--datadir=${datadi
>>   CFLAGS =+ "-I${S}/include"
>>
>>   SSTATEPOSTINSTFUNCS += "openjade_sstate_postinst"
>> +SYSROOT_PREPROCESS_FUNCS += "openjade_sysroot_preprocess"
>> +
>>
>>   # We need to do this else the source interdependencies aren't generated and
>>   # build failures can result (e.g. zero size style/Makefile.dep file)
>> @@ -66,8 +68,14 @@ openjade_sstate_postinst() {
>>   	then
>>   		# Ensure that the catalog file sgml-docbook.cat is properly
>>   		# updated when the package is installed from sstate cache.
>> -		install-catalog \
>> +		${SYSROOT_DESTDIR}${bindir_crossscripts}/install-catalog-openjade \
>>   			--add ${sysconfdir}/sgml/sgml-docbook.cat \
>>   			${sysconfdir}/sgml/openjade-${PV}.cat
>>   	fi
>>   }
>> +
>> +docbook_sgml_dtd_sysroot_preprocess () {
>
> This is not the same function name as above...
>
Good catch on Johsua's part,  Bad on my part for not completing testing 
before sending this out.  I had a build going before I send the pull 
request.

Thanks
	Sau!

>> +    install -d ${SYSROOT_DESTDIR}${bindir_crossscripts}/
>> +    install -m 755 ${STAGING_BINDIR_NATIVE}/install-catalog ${SYSROOT_DESTDIR}${bindir_crossscripts}/install-catalog-openjade
>> +}
>> +
>



  reply	other threads:[~2011-07-23  3:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-22 23:54 [PATCH 0/3] Fix for share state native binary issue Saul Wold
2011-07-22 23:54 ` [PATCH 1/3] openjade-native: Add SYSROOT_PREPROCESS_FUNC Saul Wold
2011-07-22 23:57   ` Joshua Lock
2011-07-23  3:25     ` Saul Wold [this message]
2011-07-22 23:54 ` [PATCH 2/3] docbook-sgml-dtd-native: " Saul Wold
2011-07-22 23:54 ` [PATCH 3/3] docbook-dsssl-stylesheets-native: " Saul Wold
2011-07-25 15:39 ` [PATCH 0/3] Fix for share state native binary issue Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E2A3F22.8000007@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox