From: Tom Rini <tom_rini@mentor.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH v2 5/8] siteinfo: Move the rp-pppoe entry to common-linux
Date: Mon, 25 Jul 2011 09:00:04 -0700 [thread overview]
Message-ID: <4E2D9304.6090502@mentor.com> (raw)
In-Reply-To: <1311609451.30326.244.camel@phil-desktop>
On 07/25/2011 08:57 AM, Phil Blundell wrote:
> On Fri, 2011-07-22 at 10:10 -0700, Tom Rini wrote:
>> --- a/meta/site/common-linux
>> +++ b/meta/site/common-linux
>> @@ -23,3 +23,6 @@ bash_cv_unusable_rtsigs=${bash_cv_unusable_rtsigs=no}
>> # mysql
>> ac_cv_sys_restartable_syscalls=${ac_cv_sys_restartable_syscalls=yes}
>> ac_cv_conv_longlong_to_float=${ac_cv_conv_longlong_to_float=yes}
>> +
>> +# rp-pppoe
>> +rpppoe_cv_pack_bitfields=${rpppoe_cv_pack_bitfields=rev}
>
> Is that really correct? Bitfield packing isn't an OS issue, it's
> primarily a question of compiler choice. For GCC I think it correlates
> with endianness; looking at what that test is doing, I'd expect you to
> get "reversed" on little-endian and "normal" on big-endian.
It's possible we're getting this, and have been getting this wrong on
big-endian targets but I haven't heard from Freescale this is failing
for them. I'm OK with dropping this bit out for now until we can
confirm this test on a BE machine.
--
Tom Rini
Mentor Graphics Corporation
next prev parent reply other threads:[~2011-07-25 16:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 17:10 [PATCH v2 0/8] Start consolidating siteinfo information Tom Rini
2011-07-22 17:10 ` [PATCH v2 1/8] siteinfo: Move certain samba entries to common-linux Tom Rini
2011-07-22 17:10 ` [PATCH v2 2/8] siteinfo: Move certain bash " Tom Rini
2011-07-22 17:10 ` [PATCH v2 3/8] x86_64-linux siteinfo: Add bash info Tom Rini
2011-07-22 17:10 ` [PATCH v2 4/8] siteinfo: Move certain mysql entries to common-linux Tom Rini
2011-07-22 17:10 ` [PATCH v2 5/8] siteinfo: Move the rp-pppoe entry " Tom Rini
2011-07-25 15:57 ` Phil Blundell
2011-07-25 16:00 ` Tom Rini [this message]
2011-07-25 16:40 ` Phil Blundell
2011-07-25 16:55 ` Tom Rini
2011-07-26 18:55 ` Tom Rini
2011-07-22 17:10 ` [PATCH v2 6/8] siteinfo: Move certain db entries " Tom Rini
2011-07-22 17:10 ` [PATCH v2 7/8] siteinfo: Move general realloc/malloc values to common-$libc Tom Rini
2011-07-22 17:10 ` [PATCH v2 8/8] siteinfo: Move (getpgrp|setpgrp|setgrent|*get{pwuid, grgid}) to common-libc Tom Rini
2011-07-28 0:19 ` [PATCH v2 0/8] Start consolidating siteinfo information Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2D9304.6090502@mentor.com \
--to=tom_rini@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox