From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/3] Adding pam supporting
Date: Mon, 25 Jul 2011 09:20:36 -0700 [thread overview]
Message-ID: <4E2D97D4.9050509@linux.intel.com> (raw)
In-Reply-To: <cover.1311574519.git.xiaofeng.yan@windriver.com>
On 07/25/2011 01:23 AM, Xiaofeng Yan wrote:
> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>
> Hi Saul,
>
> I modified my patches according to your suggestion.
> - Using spaces instead of tab
Xiaofeng,
As Richard already pointed out you changed the white space incorrectly,
there are 2 types of white space used in recipe files. For things that
are shell commands, we use TAB (as the file originally was doing), for
python fragments 4 spaces are used. For recipe metadata, spaces are used
to line up indentation of lists (Such as SRC_URI, EXTRA_OEMAKE, ...)
Please review
https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating#White_Space_Management
I am sorry that was not clear from my email.
Sau!
> - The patches can work only when pam is enabled
> - Using OE-Core instead of poky
>
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
> Branch: xiaofeng/pam
> Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/pam
>
> Thanks,
> Xiaofeng Yan<xiaofeng.yan@windriver.com>
> ---
>
>
> Xiaofeng Yan (3):
> openssh: Support PAM
> polkit: Support pam
> dropbear: Support pam
>
> .../openssh/openssh-5.8p2/sshd | 10 +++
> meta/recipes-connectivity/openssh/openssh_5.8p2.bb | 77 +++++++++++---------
> meta/recipes-core/dropbear/dropbear.inc | 78 +++++++++++---------
> .../dropbear/dropbear/dropbear-enable-pam.patch | 22 ++++++
> meta/recipes-core/dropbear/dropbear_0.52.bb | 2 +-
> .../polkit/polkit-0.101/polkit-1_pam.patch | 23 ++++++
> meta/recipes-extended/polkit/polkit_0.101.bb | 7 +-
> 7 files changed, 146 insertions(+), 73 deletions(-)
> create mode 100644 meta/recipes-connectivity/openssh/openssh-5.8p2/sshd
> create mode 100644 meta/recipes-core/dropbear/dropbear/dropbear-enable-pam.patch
> create mode 100644 meta/recipes-extended/polkit/polkit-0.101/polkit-1_pam.patch
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
prev parent reply other threads:[~2011-07-25 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 8:23 [PATCH 0/3] Adding pam supporting Xiaofeng Yan
2011-07-25 8:23 ` [PATCH 1/3] openssh: Support PAM Xiaofeng Yan
2011-07-25 11:45 ` Richard Purdie
2011-07-25 8:23 ` [PATCH 2/3] polkit: Support pam Xiaofeng Yan
2011-07-25 8:23 ` [PATCH 3/3] dropbear: " Xiaofeng Yan
2011-07-25 16:20 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2D97D4.9050509@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox