Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 10/22] tune/arch-powerpc: Use fpu-soft to set PPCPKGSFX_FPU
Date: Mon, 1 Aug 2011 09:50:52 -0500	[thread overview]
Message-ID: <4E36BD4C.4030909@windriver.com> (raw)
In-Reply-To: <00381DE4-B22F-4F08-BE72-8D314B8CEF15@kernel.crashing.org>

On 8/1/11 9:13 AM, Kumar Gala wrote:
> 
> On Aug 1, 2011, at 8:03 AM, Richard Purdie wrote:
> 
>> On Mon, 2011-08-01 at 00:36 -0700, Saul Wold wrote:
>>> From: Kumar Gala <galak@kernel.crashing.org>
>>>
>>> Its more likely that we explicitly set soft-floating point support for a
>>> given target than hard.  So use 'fpu-soft' in TUNE_FEATURES rather than
>>> 'fpu-hard' to determine setting 'nf' (no-float) in PPCPKGSFX_FPU.
>>>
>>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>>> ---
>>> meta/conf/machine/include/powerpc/arch-powerpc.inc |    2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> index 8cc76ab..013755d 100644
>>> --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>>> @@ -18,7 +18,7 @@ TARGET_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "soft", "", d)}
>>>
>>> ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-efs']]}"
>>>
>>> -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}"
>>> +PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "-nf", "", d)}"
>>>
>>> TUNE_PKGARCH ?= "${TUNE_ARCH}${PPCPKGSFX_FPU}"
>>
>> Whilst the change itself may or may not be ok, it would need to change
>> the various boards that are already setting or not setting fpu-hard as a
>> feature so as it stands this change is incomplete.
> 
> Which boards are you speaking of?  I'm not aware of any that set soft float at this point for PPC.

It shouldn't be the board setting it to soft-fp, but instead the tune.
Something like qemuppc can use the nf 603e tune.

--Mark

> - k
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core




  reply	other threads:[~2011-08-01 14:55 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-01  7:35 [CONSOLIDATED PATCH 00/22] Fixes Multi-Lib & M3 Saul Wold
2011-08-01  7:35 ` [PATCH 01/22] meta-environment: set correct *MULTIMACH_TARGET_SYS Saul Wold
2011-08-01  7:35 ` [PATCH 02/22] glibc: deleted Saul Wold
2011-08-01  7:35 ` [PATCH 03/22] libzypp: Fix variable substitution problem in do_archgen step Saul Wold
2011-08-01  7:35 ` [PATCH 04/22] docbook-sgml-dtd-native: Write a bak file for shared state Saul Wold
2011-08-01  7:35 ` [PATCH 05/22] docbook-dsssl-stylesheets-native: " Saul Wold
2011-08-01  7:35 ` [PATCH 06/22] openjade-native: " Saul Wold
2011-08-01  7:35 ` [PATCH 07/22] sgml-common-native: Read a catalog backup to repopulate sgml-docbook.cat Saul Wold
2011-08-01  7:36 ` [PATCH 08/22] tune/arch-powerpc64: Fix typo with 64-bit TUNE_CCARGS handling Saul Wold
2011-08-01  7:36 ` [PATCH 09/22] tune/arch-powerpc64: Remove support for soft-float from ppc64 Saul Wold
2011-08-01  7:36 ` [PATCH 10/22] tune/arch-powerpc: Use fpu-soft to set PPCPKGSFX_FPU Saul Wold
2011-08-01 13:03   ` Richard Purdie
2011-08-01 14:13     ` Kumar Gala
2011-08-01 14:50       ` Mark Hatle [this message]
2011-08-01 15:57         ` Kumar Gala
2011-08-02 18:31     ` Kumar Gala
2011-08-02 22:36       ` Richard Purdie
2011-08-01  7:36 ` [PATCH 11/22] tune-ppce500mc: Adjust PowerPC e500mc tune file to correctly set hard fpu Saul Wold
2011-08-01  7:36 ` [PATCH 12/22] sanity.bbclass: Add sanity check that TUNE_PKGARCH appears in PACKAGE_ARCHS Saul Wold
2011-08-01  7:36 ` [PATCH 13/22] sanity: Dont throw a warning if TUNE_PKGARCH is in PACKAGE_ARCHS twice Saul Wold
2011-08-01 13:03   ` Richard Purdie
2011-08-01 13:28     ` Koen Kooi
2011-08-01 14:11     ` Kumar Gala
2011-08-01 17:34       ` Khem Raj
2011-08-01 18:51         ` Kumar Gala
2011-08-01 18:59           ` Khem Raj
2011-08-02 13:39             ` Richard Purdie
2011-08-01  7:36 ` [PATCH 14/22] libzypp: Bump PR Saul Wold
2011-08-01  7:36 ` [PATCH 15/22] tune/powerpc: Cleanup setting of TUNE_PKGARCH Saul Wold
2011-08-01  9:06   ` Richard Purdie
2011-08-01  7:36 ` [PATCH 16/22] populate_sdk: Fix the introduction of sdknative packages Saul Wold
2011-08-01 13:06   ` Richard Purdie
2011-08-01 14:47     ` Mark Hatle
2011-08-01  7:36 ` [PATCH 17/22] bitbake.conf: Add default tune-${DEFAULTTUNE} override Saul Wold
2011-08-01  9:00   ` Richard Purdie
2011-08-01  9:09   ` Phil Blundell
2011-08-01 14:36     ` Mark Hatle
2011-08-01  7:36 ` [PATCH 18/22] rootfs_rpm.bbclass: Fix multilib configurations to use DEFAULTTUNE Saul Wold
2011-08-01  7:36 ` [PATCH 19/22] package_{deb, rpm, ipk}.bbclass: fix 'lingusa' typo Saul Wold
2011-08-01  7:36 ` [PATCH 20/22] arch-armv7a.inc: fix armv7a-vfp-neon -> armv7a compat case Saul Wold
2011-08-01 13:10   ` Richard Purdie
2011-08-01 13:35     ` Koen Kooi
2011-08-01  7:36 ` [PATCH 21/22] external-*toolchain: remove glibc-utils provide Saul Wold
2011-08-01 13:11   ` Richard Purdie
2011-08-01  7:36 ` [PATCH 22/22] feature-arm-thumb: Take ARM_INSTRUCTION_SET into account to decide thumb mode Saul Wold
2011-08-01 13:14   ` Richard Purdie
2011-08-01 17:46     ` Khem Raj
2011-08-05 10:59     ` Phil Blundell
2011-08-05 11:39       ` Richard Purdie
2011-08-05 14:34         ` Phil Blundell
2011-08-05 15:23           ` Khem Raj
2011-08-05 16:23             ` Richard Purdie
2011-08-01 13:20 ` [CONSOLIDATED PATCH 00/22] Fixes Multi-Lib & M3 Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E36BD4C.4030909@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox