Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Tom Rini <tom_rini@mentor.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] ghostscript: fix parallel build issue
Date: Mon, 1 Aug 2011 15:51:54 -0700	[thread overview]
Message-ID: <4E372E0A.1020504@mentor.com> (raw)
In-Reply-To: <4E3728A7.1050707@linux.intel.com>

On 08/01/2011 03:28 PM, Saul Wold wrote:
> On 07/30/2011 11:20 AM, Khem Raj wrote:
>> On Wednesday, July 27, 2011 05:34:45 PM Kang Kai wrote:
>>> From: Kang Kai<kai.kang@windriver.com>
>>>
>>> ghostscript fails some time on autobuilder, it seems a parallel build
>>> issue.
>>> Add patch to fix it.
>>>
>>> Fixes [Yocto #1202]
>>>
>>> Signed-off-by: Kang Kai<kai.kang@windriver.com>
>>> ---
>>>   .../ghostscript-9.02-parallel-make.patch           |   17
>>> +++++++++++++++++
>>> .../ghostscript/ghostscript_9.02.bb                |    3 ++-
>>>   2 files changed, 19 insertions(+), 1 deletions(-)
>>>   create mode 100644
>>> meta/recipes-extended/ghostscript/ghostscript/ghostscript-9.02-parallel-mak
>>>
>>> e.patch
>>>
>>> diff --git
>>> a/meta/recipes-extended/ghostscript/ghostscript/ghostscript-9.02-parallel-m
>>>
>>> ake.patch
>>> b/meta/recipes-extended/ghostscript/ghostscript/ghostscript-9.02-parallel-m
>>>
>>> ake.patch new file mode 100644
>>> index 0000000..76d1676
>>> --- /dev/null
>>> +++
>>> b/meta/recipes-extended/ghostscript/ghostscript/ghostscript-9.02-parallel-m
>>>
>>> ake.patch @@ -0,0 +1,17 @@
>>> +When parallel make it will fail with multi copy, see
>>> +http://bugzilla.pokylinux.org/show_bug.cgi?id=1202
>>> +
>>> +Upstream-Status: Pending
>>> +
>>> +Signed-off-by: Kang Kai<kai.kang@windriver.com>
>>> +--- ghostscript-9.02/base/unixhead.mak.orig    2011-07-27
>>> 17:06:17.749456100
>>> +0800 ++++ ghostscript-9.02/base/unixhead.mak    2011-07-27
>>> 17:06:37.449456100
>>> +0800 +@@ -54,7 +54,7 @@
>>> +
>>> + # Define generic commands.
>>> +
>>> +-CP_=cp
>>> ++CP_=cp -f
>>
>> It means it will first delete the target if it exists. Did you check
>> if this
>> is correct behavior ?
>>
> Khem,
> 
> As far as I know the file is that is being copied to is the same file
> and the CP is only used in that case, the 2 files are copied to the same
> location due to the Parallel make.

Er, that sounds like we're just changing the race around.  Now we could
get an incomplete file?

-- 
Tom Rini
Mentor Graphics Corporation



  reply	other threads:[~2011-08-01 22:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-27  9:34 [PATCH 0/1] ghostscript: fix parallel build issue Kang Kai
2011-07-27  9:34 ` [PATCH 1/1] " Kang Kai
2011-07-27 15:47   ` Richard Purdie
2011-07-30 18:20   ` Khem Raj
2011-08-01 22:28     ` Saul Wold
2011-08-01 22:51       ` Tom Rini [this message]
2011-08-02  8:03         ` Phil Blundell
2011-08-02  0:53       ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E372E0A.1020504@mentor.com \
    --to=tom_rini@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox