From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1QrENd-0005Rx-Qq for openembedded-core@lists.openembedded.org; Wed, 10 Aug 2011 21:23:54 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail.windriver.com (8.14.3/8.14.3) with ESMTP id p7AJJKMa014322 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Wed, 10 Aug 2011 12:19:20 -0700 (PDT) Received: from Macintosh-5.local (172.25.36.226) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.1.255.0; Wed, 10 Aug 2011 12:19:20 -0700 Message-ID: <4E42D9B5.3000906@windriver.com> Date: Wed, 10 Aug 2011 14:19:17 -0500 From: Mark Hatle Organization: Wind River Systems User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20110624 Thunderbird/5.0 MIME-Version: 1.0 To: References: <1312996425-4319-1-git-send-email-galak@kernel.crashing.org> In-Reply-To: <1312996425-4319-1-git-send-email-galak@kernel.crashing.org> Subject: Re: [PATCH v2] tune-ppc: Update to pass glibc configure option to get cpu specific support X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Aug 2011 19:23:54 -0000 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit I don't think the patch is correct. If these tune files are included, the GLIBC_EXTRA_OECONF is set unconditionally. It is possible to include the tune files, but not actually use the tunings. (There are cases where you might want to inherit specific tunings, etc.) Instead, I'd suggest you do: GLIBC_EXTRA_OECONF += "${@bb.utils.contains("TUNE_FEATURES", "ppc603e", "--with-cpu=603e", "", d)}" (and a similar line for the e500mc) --Mark On 8/10/11 12:13 PM, Kumar Gala wrote: > We need --with-cpu based to glibc to get proper support on 603e & e500mc > to pickup proper math libs to deal with sqrt. These core do not > implement the fsqrt[s] instructions that the normal PPC math libs > utilize. > > This causes use to not set AVAILTUNES specifically to the sub-arch only > as we arent generically compatiable. > > Signed-off-by: Kumar Gala > --- > meta/conf/machine/include/tune-ppc603e.inc | 5 ++++- > meta/conf/machine/include/tune-ppce500mc.inc | 5 ++++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/meta/conf/machine/include/tune-ppc603e.inc b/meta/conf/machine/include/tune-ppc603e.inc > index 9abb694..c673470 100644 > --- a/meta/conf/machine/include/tune-ppc603e.inc > +++ b/meta/conf/machine/include/tune-ppc603e.inc > @@ -6,6 +6,9 @@ TUNEVALID[ppc603e] = "Enable ppc603e specific processor optimizations" > TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppc603e", "-mcpu=603e", "", d)}" > TUNE_PKGARCH = "${@bb.utils.contains('TUNE_FEATURES', 'ppc603e', 'ppc603e', '${PPCPKGARCH}', d)}" > > -AVAILTUNES += "ppc603e" > +AVAILTUNES = "ppc603e" > TUNE_FEATURES_tune-ppc603e = "m32 ppc603e" > PACKAGE_EXTRA_ARCHS_tune-ppc603e = "powerpc ppc603e" > + > +# glibc configure options to get 603e specific library (for sqrt) > +GLIBC_EXTRA_OECONF += "--with-cpu=603e" > diff --git a/meta/conf/machine/include/tune-ppce500mc.inc b/meta/conf/machine/include/tune-ppce500mc.inc > index b5031f4..cdd87dc 100644 > --- a/meta/conf/machine/include/tune-ppce500mc.inc > +++ b/meta/conf/machine/include/tune-ppce500mc.inc > @@ -6,6 +6,9 @@ TUNEVALID[ppce500mc] = "Enable ppce500mc specific processor optimizations" > TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "-mcpu=e500mc", "", d)}" > TUNE_PKGARCH = "${@bb.utils.contains("TUNE_FEATURES", "ppce500mc", "ppce500mc", "${PPCPKGARCH}", d)}" > > -AVAILTUNES += "ppce500mc" > +AVAILTUNES = "ppce500mc" > TUNE_FEATURES_tune-ppce500mc = "m32 ppce500mc" > PACKAGE_EXTRA_ARCHS_tune-ppce500mc = "powerpc ppce500mc" > + > +# glibc configure options to get e500mc specific library (for sqrt) > +GLIBC_EXTRA_OECONF += "--with-cpu=e500mc"