Openembedded Core Discussions
 help / color / mirror / Atom feed
From: "Eric Bénard" <eric@eukrea.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] qt4e-demo-image: improve image
Date: Wed, 07 Sep 2011 15:30:44 +0200	[thread overview]
Message-ID: <4E677204.8000309@eukrea.com> (raw)
In-Reply-To: <201109071423.42658.paul.eggleton@linux.intel.com>

Le 07/09/2011 15:23, Paul Eggleton a écrit :
> On Wednesday 07 September 2011 14:17:10 Eric Bénard wrote:
>> use ${POKY_BASE_INSTALL} in order to have the base files and
>> ools in the image.
>>
>> ..
>>
>>   IMAGE_INSTALL += "\
>> -	busybox \
>> +	${POKY_BASE_INSTALL} \
>>   	module-init-tools \
>>   	task-qt4e-base \
>>   "
>
> Hmm, I missed this when the original patches came in; surely it would be
> better to just append to IMAGE_INSTALL after the "inherit core-image" line,
> then we start with the default value from core-image.bbclass?
>
ok I was not sure this would work this way, I'll test and send a v2.

Thanks,
Eric



      reply	other threads:[~2011-09-07 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-07 13:17 [PATCH] qt4e-demo-image: improve image Eric Bénard
2011-09-07 13:23 ` Paul Eggleton
2011-09-07 13:30   ` Eric Bénard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E677204.8000309@eukrea.com \
    --to=eric@eukrea.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox