Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] Uprev to latest version of prelink_git, fixing TLS issues
Date: Tue, 13 Sep 2011 19:53:51 -0500	[thread overview]
Message-ID: <4E6FFB1F.7040408@windriver.com> (raw)
In-Reply-To: <1c551b4b82b13aae991184a1dead6b224b369c48.1315961467.git.mark.hatle@windriver.com>

Just an FYI if anyone is curious, the actual fix is:

--- a/trunk/src/rtld/rtld.c
+++ b/trunk/src/rtld/rtld.c
@@ -1120,7 +1120,7 @@ process_one_dso (DSO *dso, int host_paths)
                   (size_t) (l->l_map_start - cur_dso_ent->dso->base));

           if (l->l_tls_modid)
-            printf (" TLS(0x%Zx, 0x%0*Zx)\n", l->l_tls_modid,
+            printf (" TLS(0x%Zx, 0x%0*Zx)\n", (size_t) l->l_tls_modid,
                     (int) size_pointer,
                     (size_t) l->l_tls_offset);
           else

l->l_tls_modid is a uint64_t....

--Mark

On 9/13/11 7:52 PM, Mark Hatle wrote:
> [YOCTO #1473]
> 
> From the upstream cross prelink respository:
> 
>     Fix printf typecast problem
> 
>     Without this fix the printed TLS(...) information is incorrect, which
>     causes the core prelinker code to incorrectly prelink.  This bug triggers
>     primarily on x86 (32-bit) hosts, targeting x86 (32-bit) targets and arm
>     targets.
> 
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> ---
>  meta/recipes-devtools/prelink/prelink_git.bb |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-devtools/prelink/prelink_git.bb b/meta/recipes-devtools/prelink/prelink_git.bb
> index 1565ca6..af6de8e 100644
> --- a/meta/recipes-devtools/prelink/prelink_git.bb
> +++ b/meta/recipes-devtools/prelink/prelink_git.bb
> @@ -8,9 +8,9 @@ and executables, so that far fewer relocations need to be resolved at \
>  runtime and thus programs come up faster."
>  LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
> -SRCREV = "964f6eba613bf1c791a2a0b858cd044f05e2f151"
> +SRCREV = "3e3f9b0876aa5ac83a783a95b8bab52cb38ed785"
>  PV = "1.0+git${SRCPV}"
> -PR = "r6"
> +PR = "r7"
>  
>  #
>  # The cron script attempts to re-prelink the system daily -- on




  reply	other threads:[~2011-09-14  0:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-14  0:52 [PATCH 0/1] Update to latest prelinker -- fix arm and x86 issues Mark Hatle
2011-09-14  0:52 ` [PATCH 1/1] Uprev to latest version of prelink_git, fixing TLS issues Mark Hatle
2011-09-14  0:53   ` Mark Hatle [this message]
2011-09-14 17:03 ` [PATCH 0/1] Update to latest prelinker -- fix arm and x86 issues Saul Wold
2011-09-14 17:11   ` Zhang, Jessica

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6FFB1F.7040408@windriver.com \
    --to=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox