Re: [PATCH 1/1] shared-mime-info: add libxml-parser-perl to DEPENDS

[Darren Hart <dvhart@linux.intel.com>]

On 09/22/2011 12:58 PM, Richard Purdie wrote:
> On Thu, 2011-09-22 at 11:49 -0700, Darren Hart wrote:
>> Fixes [YOCTO #1514]
>>
>> Building core-image-minimal on qemuppc (and likely others) can fail in
>> the shared-mime-info configure step with the following error:
>>
>> checking for XML::Parser... configure: error: XML::Parser perl module is
>> required for intltool
>>
>> Adding libxml-parser-perl to DEPENDS allows share-mime-info-native to build
>> successfully.
>>
>> Testing: build tested the native version on qemuppc. I run into tool chain
>> build failures before I can get to building the target version.
>>
>> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
>> CC: Joshua Lock <josh@linux.intel.com>
>> ---
>>  .../shared-mime-info/shared-mime-info.inc          |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-support/shared-mime-info/shared-mime-info.inc b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> index 64eef9d..e206305 100644
>> --- a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> +++ b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>> @@ -5,8 +5,8 @@ SECTION = "base"
>>  LICENSE = "GPLv2+"
>>  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>>  
>> -DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native"
>> -DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native"
>> +DEPENDS = "libxml2 intltool-native glib-2.0 shared-mime-info-native libxml-parser-perl"
>> +DEPENDS_virtclass-native = "libxml2-native intltool-native glib-2.0-native libxml-parser-perl-native"
>>  
>>  SRC_URI = "http://freedesktop.org/~hadess/shared-mime-info-${PV}.tar.bz2"
> 
> 
> There must be some underlying problem here. intltool-native should
> depend on libxml-parser-perl-native so it should already be built. We
> need to fix the underlying issue, not the symptom :/

So intltool.inc:

DEPENDS = "libxml-parser-perl-native"
#RDEPENDS_${PN} = "libxml-parser-perl"
RRECOMMENDS_${PN} = "perl-modules"
RRECOMMENDS_${PN}_virtclass-native = ""

Shouldn't this instead look like:

DEPENDS = "libxml-parser-perl"
DEPENDS_virtclass-native = "libxml-parser-perl-native"

Dropping my change above and using this fix instead allows the build to
complete. Does look like the right fix to you? Shall I send this as a
patch?

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel