Re: [PATCH] intltool: inherit gettext to add missing dependency on gettext

From: Saul Wold <saul.wold@intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] intltool: inherit gettext to add missing dependency on gettext
Date: Wed, 28 Sep 2011 10:17:41 -0700	[thread overview]
Message-ID: <4E8356B5.7000901@intel.com> (raw)
In-Reply-To: <CAMKF1sphSpMstEoqqQmhF9NeHnAuJBvc3F5vcewB3ALwSA7o2w@mail.gmail.com>

On 09/25/2011 05:22 PM, Khem Raj wrote:
> On Sun, Sep 25, 2011 at 10:16 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org>  wrote:
>> On Sat, 2011-09-24 at 17:11 -0700, Khem Raj wrote:
>>> Fixes the error like below
>>>
>>> | configure: error: GNU gettext tools not found; required for intltool
>>> | + bbfatal 'oe_runconf failed'
>>> | + echo 'ERROR: oe_runconf failed'
>>> | ERROR: oe_runconf failed
>>>
>>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>> ---
>>>   meta/recipes-devtools/intltool/intltool.inc       |    2 +-
>>>   meta/recipes-devtools/intltool/intltool_0.40.6.bb |    2 +-
>>>   2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/meta/recipes-devtools/intltool/intltool.inc b/meta/recipes-devtools/intltool/intltool.inc
>>> index 23a1ee9..1e54feb 100644
>>> --- a/meta/recipes-devtools/intltool/intltool.inc
>>> +++ b/meta/recipes-devtools/intltool/intltool.inc
>>> @@ -12,7 +12,7 @@ DEPENDS_virtclass-native = "libxml-parser-perl-native"
>>>   RRECOMMENDS_${PN} = "perl-modules"
>>>   RRECOMMENDS_${PN}_virtclass-native = ""
>>>
>>> -inherit autotools pkgconfig perlnative
>>> +inherit autotools pkgconfig perlnative gettext
>>>
>>>   export PERL = "${bindir}/env perl"
>>>   PERL_virtclass-native = "/usr/bin/env nativeperl"
>>> diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>> index e9871fc..eae2b85 100644
>>> --- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>> +++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
>>> @@ -1,7 +1,7 @@
>>>   require intltool.inc
>>>   LICENSE="GPLv2"
>>>   LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>>> -PR = "r5"
>>> +PR = "r6"
>>>
>>>   SRC_URI_append = " file://intltool-nowarn-0.40.0.patch \
>>>                      ${NATIVEPATCHES} \
>>
>> I investigated this one and intltool requires gettext at runtime, not
>> build time. Which package did you see the above error from as I suspect
>> it wasn't intltool itself but something using it?
>
> It was intltool itself. The situation happens during rebuild when
> intltool and gettext-native both are to be rebuilt
> and other deps are already there. it doesnt usually happen since we
> build gettext-native pretty early.

Khem,

I verified this, and I also noted that if I did a cleansstate on 
intltool and gettext-native, that gettext-native would be rebuilt, but I 
also checked bitbake -b intltool and it completed successfully with no 
errors, so the dependency is buried in one of intltool's dependencies, 
thus getting built.

So there is no direct dependency on gettext-native by intltool.

Sau!

>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core