From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com ([143.182.124.22] helo=azsmga101.ch.intel.com) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RG2Qy-0002mE-R1 for openembedded-core@lists.openembedded.org; Tue, 18 Oct 2011 07:41:53 +0200 Received: from mail-ww0-f44.google.com ([74.125.82.44]) by mga03.intel.com with ESMTP/TLS/RC4-SHA; 17 Oct 2011 22:36:01 -0700 Received: by wwe6 with SMTP id 6so184718wwe.13 for ; Mon, 17 Oct 2011 22:36:00 -0700 (PDT) Received: by 10.227.38.217 with SMTP id c25mr312028wbe.60.1318916159310; Mon, 17 Oct 2011 22:35:59 -0700 (PDT) Received: from [10.6.18.230] (c-71-193-189-117.hsd1.wa.comcast.net. [71.193.189.117]) by mx.google.com with ESMTPS id 11sm1321041wby.15.2011.10.17.22.35.56 (version=SSLv3 cipher=OTHER); Mon, 17 Oct 2011 22:35:58 -0700 (PDT) Message-ID: <4E9D103B.10506@intel.com> Date: Mon, 17 Oct 2011 22:35:55 -0700 From: Saul Wold Organization: Intel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: In-Reply-To: Subject: Re: [PATCH 1/2] qmmp: update to 0.5.2 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2011 05:41:53 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 10/17/2011 10:21 PM, Xiaofeng Yan wrote: > From: Xiaofeng Yan > > The new version of qmmp can run on core-image-sato by test. > $qmmp *.mp3 > > Signed-off-by: Xiaofeng Yan > --- > meta/recipes-qt/qt-apps/qmmp_0.5.2.bb | 49 +++++++++++++++++++++++++++++++++ > 1 files changed, 49 insertions(+), 0 deletions(-) > create mode 100644 meta/recipes-qt/qt-apps/qmmp_0.5.2.bb > > diff --git a/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb > new file mode 100644 > index 0000000..f31409b > --- /dev/null > +++ b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb > @@ -0,0 +1,49 @@ > +dESCRIPTION = "Qmmp (Qt-based Multimedia Player) is an audio-player, written with help of Qt library" > +HOMEPAGE = "http://qmmp.ylsoftware.com" > +LICENSE = "GPLv2" > +LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833" > +SECTION = "multimedia" > + > +PR = "r3" > + > +PROVIDES = "qmmp" > +DEPENDS = "qt4-x11-free taglib libmad libvorbis libogg alsa-lib" > +RDEPENDS_${PN} += "taglib alsa-lib libmad curl" > + > +SRC_URI = "http://qmmp.ylsoftware.com/files/${BPN}-${PV}.tar.bz2" > + > +SRC_URI[md5sum] = "20852f3cce3471bfc5affa9b2e947dc6" > +SRC_URI[sha256sum] = "6391dec020d2a381d7f4b7890fae6c49eadf88b3c9aef571fe3c5e96140822ec" > + > + > +PARALLEL_MAKE = "" > + > +inherit qmake2 cmake > + > +export EXTRA_OECMAKE = "-DQT_QMAKE_EXECUTABLE=${OE_QMAKE_QMAKE} \ > + -DQT_LRELEASE_EXECUTABLE=${OE_QMAKE_LRELEASE} \ > + -DQT_MOC_EXECUTABLE=${OE_QMAKE_MOC} \ > + -DQT_UIC_EXECUTABLE=${OE_QMAKE_UIC} \ > + -DQT_RCC_EXECUTABLE=${OE_QMAKE_RCC} \ > + -DQT_LIBRARY_DIR=${OE_QMAKE_LIBDIR_QT} \ > + -DQT_HEADERS_DIR=${OE_QMAKE_INCDIR_QT} \ > + -DQT_QTCORE_INCLUDE_DIR=${OE_QMAKE_INCDIR_QT}/QtCore \ > + " > + > +FILES_${PN} =+ "\ > + ${libdir}/qmmp/*/*.so \ > + ${datadir}/icons/* \ > + ${datadir}/qmmp/images/* \ > + ${datadir}/applications/qmmp.desktop \ > + " > + Xiaofeng, I was looking into this also, I think it would be better to split all the various plugins into separate packages using do_split_packages(), in the packages.bbclass. I started with this code: > PACKAGES_DYNAMIC = "qmmp-plugin-*" > > python populate_packages_prepend () { > qmmp_libdir = bb.data.expand('${libdir}/qmmp', d) > > do_split_packages(d, qmmp_libdir, '^(.*)/(.*)\.so$', 'qmmp-plugin-%s-%s', 'Qmmp %s Plugin for %s', extra_depends='') > } But have not completed it yet, if you have time to investigate further and complete this correctly, there might be a problem with using multiple Regular expressions in the do_split_packages code, but I have not fully debugged this yet. Please let me know if you can complete this task. Thanks Sau! > +FILES_${PN}-dbg += "\ > + ${libdir}/qmmp/*/.debug/* \ > + " > + > +PACKAGES += "${PN}-plugin-input-mad ${PN}-plugin-input-vorbis" > + > +FILES_${PN}-plugin-input-mad = "${libdir}/qmmp/Input/libmad.so" > +RDEPENDS_${PN}-plugin-input-mad = "libmad" > +FILES_${PN}-plugin-input-vorbis = "${libdir}/qmmp/Input/libvorbis.so" > +RDEPENDS_${PN}-plugin-input-vorbis = "libvorbis libogg"