From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RGTXp-0004uK-GU for openembedded-core@lists.openembedded.org; Wed, 19 Oct 2011 12:38:45 +0200 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail.windriver.com (8.14.3/8.14.3) with ESMTP id p9JAWrwB027491 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Wed, 19 Oct 2011 03:32:54 -0700 (PDT) Received: from [128.224.162.146] (128.224.162.146) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.1.255.0; Wed, 19 Oct 2011 03:32:53 -0700 Message-ID: <4E9EA6E7.9000409@windriver.com> Date: Wed, 19 Oct 2011 18:31:03 +0800 From: Xiaofeng Yan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: References: <4E9D103B.10506@intel.com> <4E9D123F.6090102@windriver.com> In-Reply-To: <4E9D123F.6090102@windriver.com> X-Originating-IP: [128.224.162.146] Subject: Re: [PATCH 1/2] qmmp: update to 0.5.2 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2011 10:38:46 -0000 Content-Type: multipart/alternative; boundary="------------070105020008080600060406" --------------070105020008080600060406 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mail.windriver.com id p9JAWrwB027491 On 2011=E5=B9=B410=E6=9C=8818=E6=97=A5 13:44, Xiaofeng Yan wrote: > On 2011=E5=B9=B410=E6=9C=8818=E6=97=A5 13:35, Saul Wold wrote: >> On 10/17/2011 10:21 PM, Xiaofeng Yan wrote: >>> From: Xiaofeng Yan >>> >>> The new version of qmmp can run on core-image-sato by test. >>> $qmmp *.mp3 >>> >>> Signed-off-by: Xiaofeng Yan >>> --- >>> meta/recipes-qt/qt-apps/qmmp_0.5.2.bb | 49=20 >>> +++++++++++++++++++++++++++++++++ >>> 1 files changed, 49 insertions(+), 0 deletions(-) >>> create mode 100644 meta/recipes-qt/qt-apps/qmmp_0.5.2.bb >>> >>> diff --git a/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb=20 >>> b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb >>> new file mode 100644 >>> index 0000000..f31409b >>> --- /dev/null >>> +++ b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb >>> @@ -0,0 +1,49 @@ >>> +dESCRIPTION =3D "Qmmp (Qt-based Multimedia Player) is an=20 >>> audio-player, written with help of Qt library" >>> +HOMEPAGE =3D "http://qmmp.ylsoftware.com" >>> +LICENSE =3D "GPLv2" >>> +LIC_FILES_CHKSUM =3D=20 >>> "file://COPYING;md5=3D393a5ca445f6965873eca0259a17f833" >>> +SECTION =3D "multimedia" >>> + >>> +PR =3D "r3" >>> + >>> +PROVIDES =3D "qmmp" >>> +DEPENDS =3D "qt4-x11-free taglib libmad libvorbis libogg alsa-lib" >>> +RDEPENDS_${PN} +=3D "taglib alsa-lib libmad curl" >>> + >>> +SRC_URI =3D "http://qmmp.ylsoftware.com/files/${BPN}-${PV}.tar.bz2" >>> + >>> +SRC_URI[md5sum] =3D "20852f3cce3471bfc5affa9b2e947dc6" >>> +SRC_URI[sha256sum] =3D=20 >>> "6391dec020d2a381d7f4b7890fae6c49eadf88b3c9aef571fe3c5e96140822ec" >>> + >>> + >>> +PARALLEL_MAKE =3D "" >>> + >>> +inherit qmake2 cmake >>> + >>> +export EXTRA_OECMAKE =3D "-DQT_QMAKE_EXECUTABLE=3D${OE_QMAKE_QMAKE} = \ >>> + -DQT_LRELEASE_EXECUTABLE=3D${OE_QMAKE_LRELEASE} \ >>> + -DQT_MOC_EXECUTABLE=3D${OE_QMAKE_MOC} \ >>> + -DQT_UIC_EXECUTABLE=3D${OE_QMAKE_UIC} \ >>> + -DQT_RCC_EXECUTABLE=3D${OE_QMAKE_RCC} \ >>> + -DQT_LIBRARY_DIR=3D${OE_QMAKE_LIBDIR_QT} \ >>> + -DQT_HEADERS_DIR=3D${OE_QMAKE_INCDIR_QT} \ >>> + -DQT_QTCORE_INCLUDE_DIR=3D${OE_QMAKE_INCDIR_QT}/QtCore \ >>> + " >>> + >>> +FILES_${PN} =3D+ "\ >>> + ${libdir}/qmmp/*/*.so \ >>> + ${datadir}/icons/* \ >>> + ${datadir}/qmmp/images/* \ >>> + ${datadir}/applications/qmmp.desktop \ >>> + " >>> + >> Xiaofeng, >> >> I was looking into this also, I think it would be better to split all=20 >> the various plugins into separate packages using do_split_packages(), = in >> the packages.bbclass. >> >> I started with this code: >>> PACKAGES_DYNAMIC =3D "qmmp-plugin-*" >>> >>> python populate_packages_prepend () { >>> qmmp_libdir =3D bb.data.expand('${libdir}/qmmp', d) >>> >>> do_split_packages(d, qmmp_libdir, '^(.*)/(.*)\.so$',=20 >>> 'qmmp-plugin-%s-%s', 'Qmmp %s Plugin for %s', extra_depends=3D'') >>> } >> >> But have not completed it yet, if you have time to investigate=20 >> further and complete this correctly, there might be a problem with=20 >> using multiple Regular expressions in the do_split_packages code, but=20 >> I have not fully debugged this yet. >> >> Please let me know if you can complete this task. >> Hi saul, The following is my modification to qmmp_0.5.2.bb. Please review it. I want to get a reply about how to ship files in ${datadir} for qmmp. I=20 shipped them to FILES_${PN} because qmmp need these files when starting=20 up. Do you think that they should be packaged like qmmp-plugin-* ? Please give me your suggestion and I will modify this file. PACKAGES_DYNAMIC +=3D "qmmp-plugin-*" python populate_packages_prepend () { qmmp_libdir =3D bb.data.expand('${libdir}/qmmp', d) do_split_packages(d, qmmp_libdir, '^lib(.*)\.so$',=20 'qmmp-plugin-%s', 'Qmmp %s Plugin for', recursive=3DTrue,extra_depends=3D= '') } FILES_${PN} =3D "\ ${bindir}/qmmp \ ${libdir}/lib*${SOLIBS} \ ${datadir}/icons/* \ ${datadir}/qmmp/images/* \ ${datadir}/applications/* \ " FILES_${PN}-dbg +=3D "\ ${libdir}/qmmp/*/.debug/* \ " PACKAGES +=3D "${PN}-plugin-input-mad ${PN}-plugin-input-vorbis " FILES_${PN}-plugin-input-mad =3D "${libdir}/qmmp/Input/libmad.so" RDEPENDS_${PN}-plugin-input-mad =3D "libmad" FILES_${PN}-plugin-input-vorbis =3D "${libdir}/qmmp/Input/libvorbis.so" RDEPENDS_${PN}-plugin-input-vorbis =3D "libvorbis libogg" Thanks Yan > Thanks for your reply and I will investigate it according to your=20 > suggestion. > > Thanks > Yan >> Thanks >> Sau! >> >> >>> +FILES_${PN}-dbg +=3D "\ >>> + ${libdir}/qmmp/*/.debug/* \ >>> + " >>> + >>> +PACKAGES +=3D "${PN}-plugin-input-mad ${PN}-plugin-input-vorbis" >>> + >>> +FILES_${PN}-plugin-input-mad =3D "${libdir}/qmmp/Input/libmad.so" >>> +RDEPENDS_${PN}-plugin-input-mad =3D "libmad" >>> +FILES_${PN}-plugin-input-vorbis =3D "${libdir}/qmmp/Input/libvorbis.= so" >>> +RDEPENDS_${PN}-plugin-input-vorbis =3D "libvorbis libogg" >> >> > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core --------------070105020008080600060406 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mail.windriver.com id p9JAWrwB027491 On 2011=E5=B9=B410=E6=9C=8818=E6=97=A5 13:44, Xiaofeng Yan wrote:
On 2011=E5=B9=B410=E6=9C=8818=E6=97=A5 13:35, Saul Wold wrote:
On 10/17/2011 10:21 PM, Xiaofeng Yan wrote:
From: Xiaofeng Yan<xiaofeng.yan@windriver.com>

The new version of qmmp can run on core-image-sato by test.
$qmmp *.mp3

Signed-off-by: Xiaofeng Yan<xiaofeng.yan@windriver.com&= gt;
---
meta/recipes-qt/qt-apps/qmmp_0.5.2.bb | 49 +++++++++++++++++++++++++++++++++
1 files changed, 49 insertions(+), 0 deletions(-)
create mode 100644 meta/recipes-qt/qt-apps/qmmp_0.5.2.bb

diff --git a/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb
new file mode 100644
index 0000000..f31409b
--- /dev/null
+++ b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb
@@ -0,0 +1,49 @@
+dESCRIPTION =3D "Qmmp (Qt-based Multimedia Player) is an audio-player, written with help of Qt library"
+HOMEPAGE =3D "http://qmmp.ylsoftware.com"
+LICENSE =3D "GPLv2"
+LIC_FILES_CHKSUM =3D "file://COPYING;md5=3D393a5ca445f696587= 3eca0259a17f833"
+SECTION =3D "multimedia"
+
+PR =3D "r3"
+
+PROVIDES =3D "qmmp"
+DEPENDS =3D "qt4-x11-free taglib libmad libvorbis libogg alsa-lib"
+RDEPENDS_${PN} +=3D "taglib alsa-lib libmad curl"
+
+SRC_URI =3D "http://qmmp.ylsoftware.com/files/${BP= N}-${PV}.tar.bz2"
+
+SRC_URI[md5sum] =3D "20852f3cce3471bfc5affa9b2e947dc6"
+SRC_URI[sha256sum] =3D "6391dec020d2a381d7f4b7890fae6c49eadf88b3c9aef571fe3c5e96140822= ec"
+
+
+PARALLEL_MAKE =3D ""
+
+inherit qmake2 cmake
+
+export EXTRA_OECMAKE =3D "-DQT_QMAKE_EXECUTABLE=3D${OE_QMAKE_QMAKE} \
+ -DQT_LRELEASE_EXECUTABLE=3D${OE_QMAKE_LRELEASE} \
+ -DQT_MOC_EXECUTABLE=3D${OE_QMAKE_MOC} \
+ -DQT_UIC_EXECUTABLE=3D${OE_QMAKE_UIC} \
+ -DQT_RCC_EXECUTABLE=3D${OE_QMAKE_RCC} \
+ -DQT_LIBRARY_DIR=3D${OE_QMAKE_LIBDIR_QT} \
+ -DQT_HEADERS_DIR=3D${OE_QMAKE_INCDIR_QT} \
+ -DQT_QTCORE_INCLUDE_DIR=3D${OE_QMAKE_INCDIR_QT}/QtCore \
+ "
+
+FILES_${PN} =3D+ "\
+ ${libdir}/qmmp/*/*.so \
+ ${datadir}/icons/* \
+ ${datadir}/qmmp/images/* \
+ ${datadir}/applications/qmmp.desktop \
+ "
+
Xiaofeng,

I was looking into this also, I think it would be better to split all the various plugins into separate packages using do_split_packages(), in
the packages.bbclass.

I started with this code:
PACKAGES_DYNAMIC =3D "qmmp-plugin-*"

python populate_packages_prepend () {
qmmp_libdir =3D bb.data.expand('${libdir}/qmmp', d)

do_split_packages(d, qmmp_libdir, '^(.*)/(.*)\.so$', 'qmmp-plugin-%s-%s', 'Qmmp %s Plugin for %s', extra_depends=3D'')
}

But have not completed it yet, if you have time to investigate further and complete this correctly, there might be a problem with using multiple Regular expressions in the do_split_packages code, but I have not fully debugged this yet.

Please let me know if you can complete this task.

Hi saul,

The following is my modification to qmmp_0.5.2.bb. Please review it.<= br> I want to get a reply about how to ship files in ${datadir} for qmmp. I shipped them to FILES_${PN} because qmmp need these files when starting up. Do you think that they should be packaged like qmmp-plugin-* ?

Please give me your suggestion and I will modify this file.


PACKAGES_DYNAMIC +=3D "qmmp-plugin-*"


python populate_packages_prepend () {
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 qmmp_libdir =3D bb.data.= expand('${libdir}/qmmp', d)
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 do_split_packages(d, qmm= p_libdir, '^lib(.*)\.so$', 'qmmp-plugin-%s', 'Qmmp %s Plugin for', recursive=3DTrue,extra_depends=3D'')
}

FILES_${PN} =3D "\
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ${bindir}/qmmp \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ${libdir}/lib*${SOLIBS} \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ${datadir}/icons/* \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ${datadir}/qmmp/images/* \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ${datadir}/applications/* \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 "

FILES_${PN}-dbg +=3D "\
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 ${libdir}/qmmp/*/.debug/* \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 "

PACKAGES +=3D "${PN}-plugin-input-mad ${PN}-plugin-input-vorbis "
FILES_${PN}-plugin-input-mad =3D "${libdir}/qmmp/Input/libmad.so" RDEPENDS_${PN}-plugin-input-mad =3D "libmad"
FILES_${PN}-plugin-input-vorbis =3D "${libdir}/qmmp/Input/libvorbis.so"
RDEPENDS_${PN}-plugin-input-vorbis =3D "libvorbis libogg"


Thanks
Yan
Thanks for your reply and I will investigate it according to your suggestion.

Thanks
Yan
Thanks
Sau!


+FILES_${PN}-dbg +=3D "\
+ ${libdir}/qmmp/*/.debug/* \
+ "
+
+PACKAGES +=3D "${PN}-plugin-input-mad ${PN}-plugin-input-vorbis"
+
+FILES_${PN}-plugin-input-mad =3D "${libdir}/qmmp/Input/libmad.so"
+RDEPENDS_${PN}-plugin-input-mad =3D "libmad"
+FILES_${PN}-plugin-input-vorbis =3D "${libdir}/qmmp/Input/libvorbis.so"
+RDEPENDS_${PN}-plugin-input-vorbis =3D "libvorbis libogg"




_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-b= in/mailman/listinfo/openembedded-core

--------------070105020008080600060406--