From: Saul Wold <saul.wold@intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH] insane.bbclass: print full path on invalid LICENSE_FILES_CHKSUM
Date: Thu, 20 Oct 2011 10:19:03 -0700 [thread overview]
Message-ID: <4EA05807.3090506@intel.com> (raw)
In-Reply-To: <4E9DCCE8.8090009@linux.intel.com>
On 10/18/2011 12:00 PM, Darren Hart wrote:
> Currently only the basename is printed when os.path.isfile() returns a failure
> for the license file. If the file is present, but in the wrong directory, this
> can be non-obvious to debug. Use the full path instead.
>
> Make a minor grammatical correction in the error message while we're at it.
>
> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
> ---
> meta/classes/insane.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
> index b861e85..017f7be 100644
> --- a/meta/classes/insane.bbclass
> +++ b/meta/classes/insane.bbclass
> @@ -330,7 +330,7 @@ def package_qa_check_license(workdir, d):
> (type, host, path, user, pswd, parm) = bb.decodeurl(url)
> srclicfile = os.path.join(srcdir, path)
> if not os.path.isfile(srclicfile):
> - raise bb.build.FuncFailed( pn + ": LIC_FILES_CHKSUM points to invalid file: " + path)
> + raise bb.build.FuncFailed( pn + ": LIC_FILES_CHKSUM points to an invalid file: " + srclicfile)
>
> if 'md5' not in parm:
> bb.error(pn + ": md5 checksum is not specified for ", url)
Merged into OE-Core
Thanks
Sau!
prev parent reply other threads:[~2011-10-20 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 19:00 [PATCH] insane.bbclass: print full path on invalid LICENSE_FILES_CHKSUM Darren Hart
2011-10-20 17:19 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA05807.3090506@intel.com \
--to=saul.wold@intel.com \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox