Re: [PATCH 4/4] gst-plugins-good: correctly handle gconf schema

[Joshua Lock <josh@linux.intel.com>]

On 10/20/2011 11:03 AM, Koen Kooi wrote:
> Op 20 okt. 2011 om 19:41 heeft Joshua Lock <josh@linux.intel.com> het volgende geschreven:
> 
>>
>>
>> On 10/19/2011 10:41 PM, Koen Kooi wrote:
>>>
>>> Op 20 okt. 2011, om 00:49 heeft Joshua Lock het volgende geschreven:
>>>
>>>> Add the shipped gconf schema to the base package and inherit the gconf class
>>>> so that scheme processing is handled via post* scripts.
>>>>
>>>> Signed-off-by: Joshua Lock <josh@linux.intel.com>
>>>> ---
>>>> .../gstreamer/gst-plugins-good_0.10.30.bb          |    6 ++++--
>>>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.30.bb b/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.30.bb
>>>> index 96855aa..d63b09a 100644
>>>> --- a/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.30.bb
>>>> +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-good_0.10.30.bb
>>>> @@ -7,9 +7,9 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
>>>>
>>>> DEPENDS += "gst-plugins-base gconf cairo jpeg libpng gtk+ zlib libid3tag flac \
>>>>        speex libsoup-2.4 pulseaudio"
>>>> -PR = "r2"
>>>> +PR = "r3"
>>>>
>>>> -inherit gettext
>>>> +inherit gettext gconf
>>>>
>>>> EXTRA_OECONF += "--disable-aalib --disable-esd --disable-shout2 --disable-libcaca --disable-hal --without-check"
>>>>
>>>> @@ -20,3 +20,5 @@ do_configure_prepend() {
>>>>
>>>> SRC_URI[md5sum] = "62fd7a3ef187c4f99b3d7c352d58dae9"
>>>> SRC_URI[sha256sum] = "b12cba90b27d8423cd0a808939098d19db3996cfb9bf528507c6321782e095f6"
>>>> +
>>>> +FILES_${PN} += "${sysconfdir}/gconf/schemas/gstreamer-0.10.schemas"
>>>
>>> If think that schema needs to go into the gconf-elements plugin package, no?
>>
>> Is that a statement or a question? That was my hunch but I was having a
>> hard time finding anything which explicitly stated that.
> 
> It was a question, there are few plugins that can hook into gconf, I lost track which plugins are in -good

OK, I don't know either. gconf-elements is a part of plugins-good and
some Makefile reading leads me to believe that the schema should be
shipped with that package.

Thanks Koen, updated pull request due shortly.

Cheers,
Joshua
-- 
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre