From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RNO3z-000388-JA for openembedded-core@lists.openembedded.org; Mon, 07 Nov 2011 13:12:32 +0100 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail.windriver.com (8.14.3/8.14.3) with ESMTP id pA7C6H5V009151 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Mon, 7 Nov 2011 04:06:17 -0800 (PST) Received: from [128.224.162.146] (128.224.162.146) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.1.255.0; Mon, 7 Nov 2011 04:06:17 -0800 Message-ID: <4EB7C898.1060001@windriver.com> Date: Mon, 7 Nov 2011 20:01:28 +0800 From: Xiaofeng Yan User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: <94D2553B-05A3-4DA1-918D-26E66F3E9DCC@dominion.thruhere.net> In-Reply-To: <94D2553B-05A3-4DA1-918D-26E66F3E9DCC@dominion.thruhere.net> X-Originating-IP: [128.224.162.146] Subject: Re: [PATCH 1/2] qmmp: update to 0.5.2 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2011 12:12:32 -0000 Content-Type: multipart/alternative; boundary="------------070700060500050606000808" --------------070700060500050606000808 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 2011?11?07? 19:58, Koen Kooi wrote: > Op 7 nov. 2011, om 12:57 heeft Xiaofeng Yan het volgende geschreven: > >> From: Xiaofeng Yan >> >> qmmp: remove old recipe and add new recipe >> >> Use do_split_package for each grouping and name them correctly besides updating package. >> The format to name plugins of qmmp: >> qmmp-plugin-- with the Description: Qmmp plugin for %s" >> >> Signed-off-by: Xiaofeng Yan >> --- >> meta/recipes-qt/qt-apps/qmmp_0.5.1.bb | 47 ---------------------------- >> >> -FILES_${PN}-plugin-input-mad = "${libdir}/qmmp/Input/libmad.so" >> -RDEPENDS_${PN}-plugin-input-mad = "libmad" >> -FILES_${PN}-plugin-input-vorbis = "${libdir}/qmmp/Input/libvorbis.so" >> -RDEPENDS_${PN}-plugin-input-vorbis = "libvorbis libogg" >> diff --git a/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb >> new file mode 100644 >> index 0000000..035b50f >> --- /dev/null >> +++ b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb >> @@ -0,0 +1,54 @@ >> +dESCRIPTION = "Qmmp (Qt-based Multimedia Player) is an audio-player, written with help of Qt library" >> +HOMEPAGE = "http://qmmp.ylsoftware.com" >> +LICENSE = "GPLv2" >> +LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833" >> +SECTION = "multimedia" >> + >> +PR = "r0" >> + >> +DEPENDS = "taglib libmad libvorbis libogg alsa-lib" >> +RDEPENDS_${PN} += "taglib alsa-lib libmad curl" > RDEPENDS go below do_install, like in the old recipe. The variable follow the task order, so DEPENDS goes at the top, RDEPENDS (do_package) goes down below do_install. > Hi koen, Thank you for finding my fault, but in this recipe , do_install use default mode. I should put RDEPENDS below FILES_${PN}, right? > regards, > > Koen > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core --------------070700060500050606000808 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit On 2011年11月07日 19:58, Koen Kooi wrote:
Op 7 nov. 2011, om 12:57 heeft Xiaofeng Yan het volgende geschreven:

From: Xiaofeng Yan <xiaofeng.yan@windriver.com>

qmmp: remove old recipe and add new recipe

Use do_split_package for each grouping and name them correctly besides updating package.
The format to name plugins of qmmp:
qmmp-plugin-<group>-<library>   with the Description: Qmmp<Group>  plugin for %s"

Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
meta/recipes-qt/qt-apps/qmmp_0.5.1.bb |   47 ----------------------------

-FILES_${PN}-plugin-input-mad = "${libdir}/qmmp/Input/libmad.so"
-RDEPENDS_${PN}-plugin-input-mad = "libmad"
-FILES_${PN}-plugin-input-vorbis = "${libdir}/qmmp/Input/libvorbis.so"
-RDEPENDS_${PN}-plugin-input-vorbis = "libvorbis libogg"

      
diff --git a/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb
new file mode 100644
index 0000000..035b50f
--- /dev/null
+++ b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb
@@ -0,0 +1,54 @@
+dESCRIPTION = "Qmmp (Qt-based Multimedia Player) is an audio-player, written with help of Qt library"
+HOMEPAGE = "http://qmmp.ylsoftware.com"
+LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
+SECTION = "multimedia"
+
+PR = "r0"
+
+DEPENDS = "taglib libmad libvorbis libogg alsa-lib"
+RDEPENDS_${PN} += "taglib alsa-lib libmad curl"
RDEPENDS go below do_install, like in the old recipe. The variable follow the task order, so DEPENDS goes at the top, RDEPENDS (do_package) goes down below do_install.

Hi koen,

Thank you for finding my fault, but in this recipe , do_install use default mode. I should put RDEPENDS below  FILES_${PN}, right?
regards,

Koen
_______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

--------------070700060500050606000808--