From: Scott Garman <scott.a.garman@intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/2] useradd.bbclass: handle nativesdk case
Date: Mon, 07 Nov 2011 15:47:19 -0800 [thread overview]
Message-ID: <4EB86E07.5020907@intel.com> (raw)
In-Reply-To: <1320700315-11952-1-git-send-email-eric@eukrea.com>
Hi Eric,
Sorry to throw more churn into this, but can I ask you to submit a new
pull request for this?
In discussions with Richard today, he pointed out a few tricks that
would improve the patchset:
DEPENDS_append = "${USERADDDEPENDS}"
USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot"
USERADDDEPENDS_virtclass-nativesdk = ""
do_install[prefuncs] += "${SYSROOTFUNC}"
SYSROOTFUNC = "useradd_sysroot"
SYSROOTFUNC_virtclass-nativesdk = ""
I didn't want to take away credit for your patch, so if you'd be willing
to make these changes and respin your patch set, we'll take that.
The second thing is to avoid merge conflicts, can you rebase you
patchset on top of this branch:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgarman/useradd-rdepends-final
...and Saul has been warned to apply these patches in the correct order.
Thanks,
Scott
PS - if this is a hassle, just let me know and I'm happy to take care of it.
--
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center
next prev parent reply other threads:[~2011-11-07 23:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 1:34 useradd changes to dbus, base-passwd James Limbouris
2011-10-26 3:37 ` James Limbouris
2011-10-26 15:23 ` Mark Hatle
2011-10-26 16:52 ` Scott Garman
2011-11-06 20:31 ` Eric Bénard
2011-11-06 23:16 ` Scott Garman
2011-11-07 8:36 ` Eric Bénard
2011-11-07 18:24 ` Scott Garman
2011-11-07 21:11 ` [PATCH 1/2] useradd.bbclass: handle nativesdk case Eric Bénard
2011-11-07 21:11 ` [PATCH 2/2] dbus: fix install for virtclass-nativesdk Eric Bénard
2011-11-07 21:32 ` Scott Garman
2011-11-07 21:32 ` [PATCH 1/2] useradd.bbclass: handle nativesdk case Scott Garman
2011-11-07 23:47 ` Scott Garman [this message]
2011-11-08 8:41 ` Eric Bénard
2011-11-08 8:41 ` [PATCH 2/2] dbus: fix install for virtclass-nativesdk Eric Bénard
2011-11-08 14:19 ` Richard Purdie
2011-11-08 14:11 ` [PATCH 1/2] useradd.bbclass: handle nativesdk case Richard Purdie
2011-11-08 15:46 ` [PATCH] " Eric Bénard
2011-11-08 16:30 ` Richard Purdie
2011-11-08 8:45 ` [PATCH 1/2] " Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB86E07.5020907@intel.com \
--to=scott.a.garman@intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox