Re: [PATCH 1/1] ncurses: refactor configure to avoid configuring widec when disabled

[Darren Hart <dvhart@linux.intel.com>]

On 11/09/2011 12:33 AM, Saul Wold wrote:
> On 11/08/2011 11:08 AM, Darren Hart wrote:
>> The ENABLE_WIDEC variable can be used to disable ncurses wide character support
>> when your C library doesn't support it. Currently, the do_configure step
>> configures for both narrow and wide characters regardless and only checks
>> ENABLE_WIDEC during compilation. This leads to QA failures with host
>> contamination during configure if the C library doesn't support wide characters.
>>
>> Refactor do_configure with a new ncurses_configure helper function and only
>> configure for wide character support if ENABLE_WIDEC is true.
>>
>> Ensure that configure errors are propogated back through to do_configure.
>>
>> Tested with ENABLE_WIDEC as true and false via an ncurses bbappend on i586,
>> including basic error injection.
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> ---
>>   meta/recipes-core/ncurses/ncurses.inc |   64 +++++++++++++++++---------------
>>   1 files changed, 34 insertions(+), 30 deletions(-)
>>
>> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
>> index be7d387..d3a9b1c 100644
>> --- a/meta/recipes-core/ncurses/ncurses.inc
>> +++ b/meta/recipes-core/ncurses/ncurses.inc
>> @@ -26,6 +26,36 @@ ENABLE_WIDEC = "true"
>>   # builds.
>>   BUILD_CPPFLAGS += "-D_GNU_SOURCE"
>>
> No PR Bump!

Right, duh. Thanks for catching. I've pushed to the same location having
added:

-INC_PR = "r1"
+INC_PR = "r2"

http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=dvhart/tiny&id=170541c552017ca784f395a9b52aae6b7c9f3592

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel