From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com ([143.182.124.37]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RTc1t-0002Tx-9D for openembedded-core@lists.openembedded.org; Thu, 24 Nov 2011 17:20:05 +0100 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 24 Nov 2011 08:13:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.69,565,1315206000"; d="scan'208";a="40895801" Received: from unknown (HELO envy.home) ([10.255.15.250]) by AZSMGA002.ch.intel.com with ESMTP; 24 Nov 2011 08:13:28 -0800 Message-ID: <4ECE6D2C.1000704@linux.intel.com> Date: Thu, 24 Nov 2011 08:13:32 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: <1322146689.10818.1.camel@ted> In-Reply-To: <1322146689.10818.1.camel@ted> X-Enigmail-Version: 1.3.3 Subject: Re: [PATCH] bitbake.conf: Set BB_CONSOLELOG so we log console messages by default X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2011 16:20:05 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit I believe this is the fix for Yocto Bug 1771? If so, awesome! A one liner, something to be said for really knowing the codebase. I would only suggest a commit log which includes the bug line, motivation and the approach taken, per the contribution guidelines. Maybe something like: """"" Fixes [YOCTO #1771] The console log is often helpful for debugging issues. Difficult to reproduce bugs would benefit from a log being generated by default as it may be difficult to come by after the fact. Log to tmp/cooker.log.${DATETIME} by default. """"" Thanks, Darren On 11/24/2011 06:58 AM, Richard Purdie wrote: > Signed-off-by: Richard Purdie > --- > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf > index 01f064c..4589909 100644 > --- a/meta/conf/bitbake.conf > +++ b/meta/conf/bitbake.conf > @@ -732,6 +732,8 @@ DISTRO[unexport] = "1" > # Used by canadian-cross to handle string conversions on TARGET_ARCH where needed > TRANSLATED_TARGET_ARCH ??= "${@d.getVar('TARGET_ARCH', True).replace("_", "-")}" > > +BB_CONSOLELOG = "${TMPDIR}/cooker.log.${DATETIME}" > + > # Setup our default hash policy > BB_SIGNATURE_HANDLER ?= "basic" > BB_HASHTASK_WHITELIST ?= "(.*-cross$|.*-native$|.*-cross-initial$|.*-cross-intermediate$|^virtual:native:.*|^virtual:nativesdk:.*)" > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel