Re: [RFC PATCH 1/5] grub-efi-native: New recipe to build GRUB EFI images

[Darren Hart <dvhart@linux.intel.com>]

On 11/24/2011 03:26 AM, Richard Purdie wrote:
> On Thu, 2011-11-24 at 09:59 +0100, Koen Kooi wrote:
>> Op 24 nov. 2011, om 09:05 heeft Darren Hart het volgende geschreven:
>>
>>> Add a recipe to build the GRUB efi images. This recipe is written as
>>> a native recipe as the resulting GRUB utils are required to assemble
>>> the final image. Rather than build a native and a target recipe (and
>>> increase build times), 
>>
>> That's a false dilemma. If you write it as a regular recipe with
>> BBCLASSEXTEND=native your buildtime doesn't increase
> 
> That isn't true, if you build a target and a native version your build
> time does increase. Using BBCLASSEXTEND does improve parsing time over
> having two separate recipes though.

Right, while it isn't a huge project to build, I didn't want to
contribute to the expanding build time unnecessarily.

> 
>>  and you leave open the option of adding more BBCLASSEXTENDS if
>> someone wants to ship it in an SDK.

I think the right thing to do here is to modify the origin grub recipe
to build with the efi platform enabled if we want to ship the binaries
on the TARGET. This recipe doesn't build the grub tools for deployment,
it builds the target bootloader binary image for the boot media. That's
the distinction I'm going with anyway.

> 
> I did talk with Darren about why the recipe is the way it is and there
> are some pretty nasty issues with the way grub builds itself. I'm
> therefore ok with this as a version 1 and we can see whether there are
> any issues that result which need us to rethink the way the recipe is
> constructed. 
> 
> Its currently behaving very like the way the binutils/gcc cross recipes
> will end up (see the separate thread with Matthew) Perhaps it should be
> called grub-efi-cross even if it uses native.bbclass.

If you prefer I can change it, I don't have a strong preference for the
name. That would end up as "grub-efi-${TRANSLATED_TARGET_ARCH}-cross"
after the PN adjustment then?


-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel