From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Paul Menzel <paulepanter@users.sourceforge.net>
Subject: Re: [PATCH 3/5] self-hosted: Add ext2 utilites and perl-pod for building
Date: Sun, 11 Dec 2011 12:17:55 -0800 [thread overview]
Message-ID: <4EE50FF3.7010202@linux.intel.com> (raw)
In-Reply-To: <1323587119.8919.4.camel@mattotaupa>
On 12/10/2011 11:05 PM, Paul Menzel wrote:
> Dear Saul,
>
>
> Am Samstag, den 10.12.2011, 14:01 -0800 schrieb Saul Wold:
>> Add self-hosted-host-tools for non-build related tools
>>
>> Signed-off-by: Saul Wold<sgw@linux.intel.com>
>> ---
>> meta/recipes-core/tasks/task-self-hosted.bb | 54 +++++++++++++++-----------
>> 1 files changed, 31 insertions(+), 23 deletions(-)
>>
>> diff --git a/meta/recipes-core/tasks/task-self-hosted.bb b/meta/recipes-core/tasks/task-self-hosted.bb
>> index b3a68b4..b9bdd21 100644
>> --- a/meta/recipes-core/tasks/task-self-hosted.bb
>> +++ b/meta/recipes-core/tasks/task-self-hosted.bb
>> @@ -3,7 +3,7 @@
>> #
>>
>> DESCRIPTION = "Create Basic Image Tasks"
>> -PR = "r1"
>> +PR = "r2"
>> LICENSE = "MIT"
>> LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> @@ -14,6 +14,7 @@ PACKAGES = "\
>> task-self-hosted-sdk \
>> task-self-hosted-extended \
>> task-self-hosted-graphics \
>> + task-self-hosted-host-tools \
>> "
>>
>> ALLOW_EMPTY = "1"
>> @@ -23,13 +24,26 @@ RDEPENDS_task-self-hosted = "\
>> task-self-hosted-sdk \
>> task-self-hosted-extended \
>> task-self-hosted-graphics \
>> + task-self-hosted-host-tools \
>> + "
>> +
>> +RDEPENDS_task-self-hosted-host-tools = "\
>> + e2fsprogs \
>> + dhcp-client \
>> + genext2fs \
>> + hdparm \
>> + iptables \
>> + kernel-module-tun \
>> + kernel-module-iptable-raw \
>> + kernel-module-iptable-nat \
>> + kernel-module-iptable-mangle \
>> + kernel-module-iptable-filter \
>> + mc \
>> + screen \
>> "
>
> […]
>
> I find this patch quite hard to review, since it reorders the
> variables(?). Is there a trick to review this or are two separate
> patches better.
>
No trick, just moved a couple of items that where in the wrong place
from one task to the host-tools task.
> Could you also please check your pull request script to send
>
> <openembedded-core@lists.openembedded.org>
>
> instead of
>
> <openembedded-core@openembedded.org>
>
> and therefore answering to all messages are sent twice to the list.
>
Sure, not sure why that would be happening.
Sau!
>
> Thanks,
>
> Paul
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2011-12-11 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 22:01 [PATCH 0/5] Fixes related to self-hosted build Saul Wold
2011-12-10 22:01 ` [PATCH 1/5] ncurses: libcurses.so should link to libncurses.so Saul Wold
2011-12-10 22:01 ` [PATCH 2/5] gdk-pixbuf: Add hicolor-icon-theme as RDEPENDS Saul Wold
2011-12-11 8:52 ` Koen Kooi
2011-12-11 21:09 ` Saul Wold
2011-12-10 22:01 ` [PATCH 3/5] self-hosted: Add ext2 utilites and perl-pod for building Saul Wold
2011-12-10 23:24 ` Wolfgang Denk
2011-12-11 0:47 ` Saul Wold
2011-12-11 7:05 ` Paul Menzel
2011-12-11 20:17 ` Saul Wold [this message]
2011-12-10 22:02 ` [PATCH 4/5] texinfo: fix compile failure due target makedoc binary being used Saul Wold
2011-12-10 22:02 ` [PATCH 5/5] bitbake.conf: remove texinfo-native from ASSUME_PROVIDED Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE50FF3.7010202@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paulepanter@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox