Re: [PATCH 4/5] clutter_git: update to 1.8.2 tag

[Saul Wold <sgw@linux.intel.com>]

On 12/13/2011 01:20 PM, Paul Eggleton wrote:
> On Tuesday 13 December 2011 12:40:40 Joshua Lock wrote:
>> On 13/12/11 12:34, Khem Raj wrote:
>>> On Tue, Dec 13, 2011 at 12:24 PM, Joshua Lock<josh@linux.intel.com>
> wrote:
>>>> -SRCREV = "39db46123ed6bbbc3e6ad359a64d4d344ca9e11b"
>>>> -PV = "1.8.0+git${SRCPV}"
>>>> +# the 1.8.2 tag
>>>> +SRCREV = "9041ea42655dfc1422ce88eab931382dd400d13a"
>>>> +PV = "1.8.2+git${SRCPV}"
>>>
>>> you could also use the tag name instead of SHA for SRCREV I think
>>
>> Indeed we can, however we've seen problems which I can't recall the
>> details of in the past when doing so. Therefore I decided to avoid it
>> this time.
>
> It does work, it just forces a fetch on every parse which is not really
> desirable. It's really no hardship to use the SHA1 especially if it's
> accompanied by a comment with the corresponding tag.
>
It will also break BB_NO_NETWORK builds with a tag, because of that 
fetch lookup, to it's preferred to use the SHA SRCREV with a Tag Comment.

Sau!

> Cheers,
> Paul
>