From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com ([143.182.124.21]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1RacgW-0001Rf-HT for openembedded-core@lists.openembedded.org; Wed, 14 Dec 2011 01:27:00 +0100 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga101.ch.intel.com with ESMTP; 13 Dec 2011 16:20:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="85412924" Received: from unknown (HELO envy.home) ([10.255.12.211]) by azsmga001.ch.intel.com with ESMTP; 13 Dec 2011 16:20:03 -0800 Message-ID: <4EE7EBA0.8080703@linux.intel.com> Date: Tue, 13 Dec 2011 16:19:44 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Dmitry Eremin-Solenikov References: <1323793193-31090-1-git-send-email-dbaryshkov@gmail.com> <4EE7EA96.4080806@linux.intel.com> In-Reply-To: X-Enigmail-Version: 1.3.3 Cc: Koen Kooi , Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/9] kernel.bbclass: compile kernel and modules in a single task X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2011 00:27:00 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 12/13/2011 04:17 PM, Dmitry Eremin-Solenikov wrote: > On Wed, Dec 14, 2011 at 4:15 AM, Darren Hart wrote: >> >> >> On 12/13/2011 08:19 AM, Dmitry Eremin-Solenikov wrote: >>> There is no point in compiling kernel modules in a separate task, run >>> right after do_compile. On the other hand merging those tasks will e.g. >>> make icecc used also for modules compilation, etc. >> >> This split was done intentionally to allow tasks to be inserted between >> compile and compile_kernelmodules. See: > > Could you (or Koen) name any tasks that have to be inserted between kernel > and modules compilation please? I'll leave that to Koen as I'm confident he had a reason for doing the split. I don't make use of the split myself. -- Darren > >> >> commit 509364eb634cf148b6ac1fb5f51924f4eb6a8991 >> Author: Koen Kooi >> Date: Tue Mar 15 11:25:01 2011 +0100 >> >> kernel bbclass: split do_compile into do_compile and do_compile_modules >> >> This allows recipes to insert a custom task in between building >> *Image and modules >> >> >From OE .dev revision 615876fe218dc3feb4a3df9e6546a7b1a6376800 >> >> (From OE-Core rev: a2cc999d663407d17f41e1b0344361944993fa86) >> >> Signed-off-by: Koen Kooi >> Acked-by: Graeme Gregory >> Signed-off-by: Richard Purdie >> >> If you want to be able to use icecc, can you pull the necessary logic >> into compile_kernelmodules rather than reverting Koen's patch? >> >> Thanks, >> >> Darren >> >>> >>> Signed-off-by: Dmitry Eremin-Solenikov >>> --- >>> meta/classes/kernel.bbclass | 6 +----- >>> 1 files changed, 1 insertions(+), 5 deletions(-) >>> >>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >>> index 3f2f75a..a75c199 100644 >>> --- a/meta/classes/kernel.bbclass >>> +++ b/meta/classes/kernel.bbclass >>> @@ -89,17 +89,13 @@ kernel_do_compile() { >>> if test "${KERNEL_IMAGETYPE_FOR_MAKE}.gz" = "${KERNEL_IMAGETYPE}"; then >>> gzip -9c < "${KERNEL_IMAGETYPE_FOR_MAKE}" > "${KERNEL_OUTPUT}" >>> fi >>> -} >>> >>> -do_compile_kernelmodules() { >>> - unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE >>> if (grep -q -i -e '^CONFIG_MODULES=y$' .config); then >>> - oe_runmake ${PARALLEL_MAKE} modules CC="${KERNEL_CC}" LD="${KERNEL_LD}" >>> + oe_runmake modules CC="${KERNEL_CC}" LD="${KERNEL_LD}" >>> else >>> bbnote "no modules to compile" >>> fi >>> } >>> -addtask compile_kernelmodules after do_compile before do_install >>> >>> kernel_do_install() { >>> # >> >> -- >> Darren Hart >> Intel Open Source Technology Center >> Yocto Project - Linux Kernel > > > -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel