From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com ([192.55.52.88]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Rba0O-0000Se-Oz for openembedded-core@lists.openembedded.org; Fri, 16 Dec 2011 16:47:28 +0100 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 16 Dec 2011 07:40:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="97010187" Received: from unknown (HELO envy.home) ([10.255.12.232]) by fmsmga001.fm.intel.com with ESMTP; 16 Dec 2011 07:40:25 -0800 Message-ID: <4EEB6658.7090002@linux.intel.com> Date: Fri, 16 Dec 2011 07:40:08 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0 MIME-Version: 1.0 To: Koen Kooi References: <33febd68cae9e482a7d35c230a0b875849e86669.1324015563.git.dvhart@linux.intel.com> <630ba0b3a784737824d9b80a4aa49eed62c265fd.1324015563.git.dvhart@linux.intel.com> In-Reply-To: X-Enigmail-Version: 1.3.3 Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 2/2] dosfstools: Remove initial directory contents feature X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Dec 2011 15:47:29 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/15/2011 11:35 PM, Koen Kooi wrote: > > Op 16 dec. 2011, om 07:14 heeft Darren Hart het volgende > geschreven: > >> By using mtools, we don't need to continue to maintain and >> workaround the issues generated by the -d feature included in the >> OE version of mkdosfstools. This reduces the number of >> out-of-tree patches we have to carry by 3 and eliminates a rather >> buggy chunk of code. >> >> Drop the initial patch adding -d as well as those applied to >> improve it and those applied to work around its deficiencies. > > The meta-ti BSP layer is depending on the -b behaviour right now > :( - -B or -d? I'm removing only -d. If -d, could you use mcopy instead? See Patch 1/2 for an example of a recursive population of the image using mcopy. Alternatively, you could bbappend dosfstools in meta-ti to include these patches. Obviously we don't want to remove it from oe-core until you do one or the other, but ultimately, I think it's better that we remove it rather than continue to carry the out-of-tree patches forward. Of course, we could try to convince someone to dig in and properly fix the feature and push to get it upstream - but for licensing reasons, we'd still be stuck carrying the patches. Since mcopy works properly as it is, I feel it's the preferable option. Is anyone else making use of the -d feature? - -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJO62ZFAAoJEKbMaAwKp364kwEIAKcZsX3C9NdzQN10tr0QaAjp or+ua304+FVlxqsxupUmIA19zm9luAx2xjinmb2Bzuidf2SqBtF/yFXSlMqFGden YsuiSR83kZPulTxA7oc1VqZ2tD9mfPh3x08mPhNC81ldbpthIjDwOhKg5jyKZS29 FwUOxVzPlG460yoH73K3MiRs0IN+v8cAZTTofPFX3YcibH+hMG73r8KFsG3wHZqp GsAWRHjQfEcFgYpKMydbv18t3VFNsWNZQFIndV7GPrn0ORHQhT+ctLK9/uin7hh+ g2SJ+BBuAE3fMqSxsW+scn6dYAmx//OBHbMU3PhB7V54aBBVtLJVUfNGoNQwxkw= =DSZO -----END PGP SIGNATURE-----