Re: [PATCH 01/10] qt4-graphics-system: add

[Saul Wold <sgw@linux.intel.com>]

On 01/05/2012 11:37 AM, Otavio Salvador wrote:
> Allow setting default runtime graphics system engine for Qt4
> applications per machine.
>
> Depending on the GPU and Xorg driver, this can boost and impact
> significantly the drawing performance. The default setting is to
> 'raster' as this offer best performance for most machines GPUs.
>
> Signed-off-by: Otavio Salvador<otavio@ossystems.com.br>
> ---
>   .../qt4-graphics-system/qt4-graphics-system_1.0.bb |   27 ++++++++++++++++++++
>   1 files changed, 27 insertions(+), 0 deletions(-)
>   create mode 100644 meta/recipes-qt/qt4-graphics-system/qt4-graphics-system_1.0.bb
>
> diff --git a/meta/recipes-qt/qt4-graphics-system/qt4-graphics-system_1.0.bb b/meta/recipes-qt/qt4-graphics-system/qt4-graphics-system_1.0.bb
> new file mode 100644
> index 0000000..b3aa1e5
> --- /dev/null
> +++ b/meta/recipes-qt/qt4-graphics-system/qt4-graphics-system_1.0.bb
> @@ -0,0 +1,27 @@
> +DESCRIPTION = "Set default Qt4 Graphics System to ${QT_GRAPHICS_SYSTEM}"
> +SECTION = "x11/base"
> +LICENSE = "MIT-X"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +QT_GRAPHICS_SYSTEM ?= "raster"
> +
> +# xserver-common, x11-common
> +VIRTUAL-RUNTIME_xserver_common ?= "x11-common"
> +
Should the be initialized here or in one of the Qt tasks?

> +def _get_extra_rdepends(d):
> +    gs = d.getVar('QT_GRAPHICS_SYSTEM', 1)
> +    if gs == "opengl":
> +        return "qt4-plugin-graphicssystems-glgraphicssystem"
> +
Is this package available in OE-Core?

> +    return ""
> +
> +do_install () {
> +	install -d ${D}/${sysconfdir}/X11/Xsession.d/
> +	cfg_file=${D}/${sysconfdir}/X11/Xsession.d/85xqt-graphicssystem
> +	echo "export QT_GRAPHICSSYSTEM=${QT_GRAPHICS_SYSTEM}">  $cfg_file
> +	chmod +x $cfg_file
> +}
> +
> +RDEPENDS_${PN} = "${VIRTUAL-RUNTIME_xserver_common} ${@_get_extra_rdepends(d)}"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"