Re: [PATCH] license.bbclass base.bbclass: support for 'or' operand in LICENSE and for SPDX license names

[Andrei Gherzan <andrei@gherzan.ro>]

On 01/10/2012 06:10 PM, Chris Larson wrote:
> On Tue, Jan 10, 2012 at 9:07 AM, Andrei Gherzan<andrei@gherzan.ro>  wrote:
>> On 01/10/2012 05:34 PM, Chris Larson wrote:
>>> On Tue, Jan 10, 2012 at 8:17 AM, Andrei Gherzan<andrei@gherzan.ro>    wrote:
>>>> From: Andrei Gherzan<andrei.gherzan@windriver.com>
>>>>
>>>> A new function was defined in license.bbclass in order to correctly
>>>> exclude packages where OE-Style licence naming
>>>> is used. In this way licenses as GPL-3, GPLv3, GPLv3.0 etc will be
>>>> excluded from a non-GPLv3 build. This function
>>>> takes into consideration if 'or' operand is used.
>>>> The function defined in license.bbclass is called in base.bbclass where
>>>> packages are excluded based on
>>>> INCOMPATIBLE_LICENSE variable.
>>>>
>>>> [YOCTO #1884]
>>>> [YOCTO #1844]
>>>>
>>>> Signed-off-by: Andrei Gherzan<andrei at gherzan.ro>
>>>
>>> Out of curiosity, why are we using regex for this when we already have
>>> license parsing in the oe.license module which can handle the OR case?
>>
>> I'm using regex only for excluding '+' characters from LICENSE. The rest of
>> the work is done in oe.license.
>> If X is defined as INCOMPATIBLE_LICENSE, X+ should be exluded as well.
> Ah, right, apparently I'm blind :) We should really think about a
> generic mechanism for handling + somehow. Hmm.
No worries. Anyway, you are right about the "+" mechanism but right now 
this is a fast and complete solution.

ag