From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.windriver.com ([147.11.1.11]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Rkmlo-00024a-BO for openembedded-core@lists.openembedded.org; Wed, 11 Jan 2012 02:14:28 +0100 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca [147.11.189.40]) by mail.windriver.com (8.14.3/8.14.3) with ESMTP id q0B16qYK013837 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 10 Jan 2012 17:06:52 -0800 (PST) Received: from [128.224.162.181] (128.224.162.181) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server id 14.1.255.0; Tue, 10 Jan 2012 17:06:52 -0800 Message-ID: <4F0CE091.5050107@windriver.com> Date: Wed, 11 Jan 2012 09:06:25 +0800 From: Zumeng Chen User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6 MIME-Version: 1.0 To: Darren Hart References: <4F0C6E4F.8040108@linux.intel.com> In-Reply-To: <4F0C6E4F.8040108@linux.intel.com> X-MIME-Autoconverted: from 8bit to quoted-printable by mail.windriver.com id q0B16qYK013837 Cc: yocto@yoctoproject.org, openembedded-core@lists.openembedded.org Subject: Re: [PATCH 1/4] lttng-ust: Integrate into yocto linux X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jan 2012 01:14:28 -0000 Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable =E4=BA=8E 2012=E5=B9=B401=E6=9C=8811=E6=97=A5 00:58, Darren Hart =E5=86=99= =E9=81=93: > > On 01/10/2012 08:11 AM, Zumeng Chen wrote: > =20 >> This patch intended to integrate the LTTng UST 2.0 package, which >> contains the userspace tracer library to trace userspace codes. >> >> Signed-off-by: Zumeng Chen >> --- >> meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb | 25 ++++++++++++= ++++++++++ >> 1 files changed, 25 insertions(+), 0 deletions(-) >> create mode 100644 meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb >> >> diff --git a/meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb b/meta/r= ecipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb >> new file mode 100644 >> index 0000000..846019e >> --- /dev/null >> +++ b/meta/recipes-kernel/lttng-2.0/lttng-ust_1.9.4.bb >> @@ -0,0 +1,25 @@ >> +SUMMARY =3D "Linux Trace Toolkit Userspace Tracer 2.0" >> +DESCRIPTION =3D "The LTTng UST 2.0 package contains the userspace tra= cer library to trace userspace codes." >> +HOMEPAGE =3D "http://lttng.org/lttng2.0" >> +BUGTRACKER =3D "n/a" >> + >> +LICENSE =3D "LGPLv2.1+& BSD" >> +LIC_FILES_CHKSUM =3D "file://COPYING;md5=3De647752e045a8c45b6f583771b= d561ef \ >> + file://snprintf/snprintf.c;endline=3D32;md5=3Dd3d= 544959d8a3782b2e07451be0a903c \ >> + file://snprintf/various.h;endline=3D31;md5=3D89f2= 509b6b4682c4fc95255eec4abe44" >> + >> +inherit autotools >> + >> +DEPENDS =3D "liburcu util-linux" >> + >> +SRC_URI =3D "http://lttng.org/files/lttng-ust/lttng-ust-${PV}.tar.gz" >> + >> +SRC_URI[md5sum] =3D "0f09bb954c99cb99ab6997cd492953c1" >> +SRC_URI[sha256sum] =3D "e9ec3c55c2251b3f3b512bfa1015b0f67e35d55793850= ccea5134f7b24ee3ba1" >> + >> +S =3D "${WORKDIR}/lttng-ust-${PV}" >> + >> +# Due to liburcu not building on MIPS currently this recipe needs to >> +# be limited also. >> +# So here let us first suppport x86/arm/powerpc platforms now. >> +COMPATIBLE_HOST =3D '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux' >> =20 > We had discussed using a different comment that more clearly stated why > this is necessary and use the same comment across all the patches > implementing this. > > This applies to all 4 patches. The suggestion was in my response to > Patch 1/4 V1: > =20 Oops, sorry Darren, all fixed and really soon for V4 on OE :-) Regards, Zumeng > =20 >> Looking through documentation.conf and existing poky sources, I believ= e >> this test is correct. HOST/TARGET are the same in this case. The comme= nt >> is a bit confusing however. I believe the comment should read: >> >> # liburcu doesn't build for MIPS >> COMPATIBLE_HOST =3D '(x86_64.*|i.86.*|arm.*|powerpc.*)-linux' >> >> The key difference being "for" instead of "on". The rest of the commen= t >> is redundant with the assignment itself. This applies to all 4 patches. >> =20 > Otherwise, things look good. > > =20