From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Christopher Larson <chris_larson@mentor.com>
Subject: Re: [PATCH] ncurses-native: install to libdir, not base_libdir
Date: Tue, 17 Jan 2012 11:32:35 -0800 [thread overview]
Message-ID: <4F15CCD3.3010209@linux.intel.com> (raw)
In-Reply-To: <1326225078-18652-1-git-send-email-kergoth@gmail.com>
On 01/10/2012 11:51 AM, Christopher Larson wrote:
> From: Christopher Larson<chris_larson@mentor.com>
>
> For target, both base_libdir and libdir in sysroot can be used, as we pass
> --sysroot to the toolchain. For native, we don't do this, and we also only add
> -L<sysroot>/${libdir}, not -L<sysroot>/${base_libdir}, resulting in other
> native recipes (like readline-native) failing to find the ncurses libraries.
>
> readline-native only built successfully on hosts where it could fall back to
> their ncurses/termcap rather than the one in the sysroot.
>
> Signed-off-by: Christopher Larson<chris_larson@mentor.com>
> ---
> meta/recipes-core/ncurses/ncurses.inc | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-core/ncurses/ncurses.inc b/meta/recipes-core/ncurses/ncurses.inc
> index 8321d7b..43303b7 100644
> --- a/meta/recipes-core/ncurses/ncurses.inc
> +++ b/meta/recipes-core/ncurses/ncurses.inc
> @@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://ncurses/base/version.c;beginline=1;endline=27;md5=cbc
> SECTION = "libs"
> DEPENDS = "ncurses-native"
> DEPENDS_virtclass-native = ""
> -INC_PR = "r3"
> +INC_PR = "r4"
>
> inherit autotools binconfig multilib_header
>
> @@ -26,8 +26,8 @@ ENABLE_WIDEC ?= "true"
> # builds.
> BUILD_CPPFLAGS += "-D_GNU_SOURCE"
>
> -# tic from the -native build cannot run without setting this explicitly
> -BUILD_LDFLAGS_virtclass-native += "-Wl,-rpath,${base_libdir}"
> +# natives don't generally look in base_libdir
> +base_libdir_virtclass-native = "${libdir}"
>
> # Helper function for do_configure to allow multiple configurations
> # $1 the directory to run configure in
Merged into OE-Core along with Enrico's Patch.
Thanks
Sau!
prev parent reply other threads:[~2012-01-17 19:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 19:51 [PATCH] ncurses-native: install to libdir, not base_libdir Christopher Larson
2012-01-12 9:37 ` Martin Jansa
2012-01-12 14:25 ` Enrico Scholz
2012-01-16 15:32 ` Chris Larson
2012-01-16 17:45 ` Saul Wold
2012-01-16 19:09 ` Joshua Lock
2012-01-16 21:27 ` Chris Larson
2012-01-17 19:32 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F15CCD3.3010209@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=chris_larson@mentor.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox