From: Joshua Lock <josh@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/3] sysklogd: various fixes so it starts/stops cleanly
Date: Tue, 31 Jan 2012 22:45:14 -0800 [thread overview]
Message-ID: <4F28DF7A.6010207@linux.intel.com> (raw)
In-Reply-To: <CAP9ODKpG8L222QfS7usbp1Y9X8pi5qb2=SMiehvccBw9J7xjpw@mail.gmail.com>
On 31/01/12 18:06, Otavio Salvador wrote:
> On Tue, Jan 31, 2012 at 22:58, Joshua Lock <josh@linux.intel.com
> <mailto:josh@linux.intel.com>> wrote:
>
> @@ -46,12 +46,18 @@ do_install () {
> pkg_preinst_${PN} () {
> # all this is needed to avoid sysmlink errors,
> # because update-rc.d runs before pkg_postinst
> - if [ -e ${sysconfdir}/init.d/syslog -a ! -L
> ${sysconfdir}/init.d/syslog ]; then
> + if test "x$D" != "x"; then
> + ETC=$D/${sysconfdir}
> + else
> + ETC=${sysconfdir}
> + fi
>
>
> You might use
>
> ETC=$D${sysconfdir}
>
> and avoid the if block as a whole.
Quite right. That is cleaner, updated commit pushed to the same branch:
http://git.openembedded.org/openembedded-core-contrib/commit/?h=josh/fixes&id=937acf5b59e5a1de2cc334b069390b3ccdb055a0
Thanks for the review.
Cheers,
Joshua
--
Joshua Lock
Yocto Project "Johannes factotum"
Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-02-01 6:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 0:58 [PATCH 0/3] Misc fixes - pciutils and syslogd Joshua Lock
2012-02-01 0:58 ` [PATCH 1/3] pciutils: fix configure script for dash Joshua Lock
2012-02-01 16:08 ` Khem Raj
2012-02-01 0:58 ` [PATCH 2/3] sysklogd: various fixes so it starts/stops cleanly Joshua Lock
2012-02-01 2:06 ` Otavio Salvador
2012-02-01 6:45 ` Joshua Lock [this message]
2012-02-01 0:58 ` [PATCH 3/3] distro_tracking_fields: take sysklogd off Saul's plate Joshua Lock
2012-02-02 18:28 ` [PATCH 0/3] Misc fixes - pciutils and syslogd Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F28DF7A.6010207@linux.intel.com \
--to=josh@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox