From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Martin Jansa <martin.jansa@gmail.com>
Subject: Re: [PATCH] rootfs_ipk: remove runtime_script_required usage
Date: Thu, 02 Feb 2012 09:50:41 -0800 [thread overview]
Message-ID: <4F2ACCF1.70704@linux.intel.com> (raw)
In-Reply-To: <1327478715-11214-1-git-send-email-Martin.Jansa@gmail.com>
On 01/25/2012 12:05 AM, Martin Jansa wrote:
> * it was introduced in 87780fc09b066525e47d0f50ee5497db54d304cd
> * then partially removed in 2feba313c991170747381c7cf821a45c2cd04632
> * so remove this use too as runtime_script_required is not initialized anymore and results in
> run.do_rootfs.6328: line 235: [: -eq: unary operator expected
>
> Signed-off-by: Martin Jansa<Martin.Jansa@gmail.com>
> ---
> meta/classes/rootfs_ipk.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/rootfs_ipk.bbclass b/meta/classes/rootfs_ipk.bbclass
> index 48fb2fb..5342035 100644
> --- a/meta/classes/rootfs_ipk.bbclass
> +++ b/meta/classes/rootfs_ipk.bbclass
> @@ -90,7 +90,7 @@ fakeroot rootfs_ipk_do_rootfs () {
> rm -f ${IMAGE_ROOTFS}${opkglibdir}/lists/*
>
> if ${@base_contains("IMAGE_FEATURES", "package-management", "false", "true", d)}; then
> - if [ $runtime_script_required -eq 0 ]; then
> + if ! grep Status:.install.ok.unpacked ${IMAGE_ROOTFS}${opkglibdir}status; then
> # All packages were successfully configured.
> # update-rc.d, base-passwd are no further use, remove them now
> opkg-cl ${IPKG_ARGS} --force-depends remove update-rc.d base-passwd || true
Merged into OE-core
Thanks
Sau!
prev parent reply other threads:[~2012-02-02 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 8:05 [PATCH] rootfs_ipk: remove runtime_script_required usage Martin Jansa
2012-02-02 17:50 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2ACCF1.70704@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox