From: Peter Tworek <tworaz666@gmail.com>
To: Paul Menzel <paulepanter@users.sourceforge.net>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] busybox: Add flock utility to default configuration.
Date: Sat, 04 Feb 2012 00:55:15 +0100 [thread overview]
Message-ID: <4F2C73E3.2070708@gmail.com> (raw)
In-Reply-To: <1328291196.4220.3.camel@mattotaupa>
On 02/03/2012 06:46 PM, Paul Menzel wrote:
> Am Donnerstag, den 02.02.2012, 21:21 +0100 schrieb Peter Tworek:
>> Flock is required by by pm-utils package to function properly
> One »by« too much.
Fixed in v2, thanks.
>
>> (/usr/lib/pm-utils/functions). It's shipped in both busybox and
>> util-linux. Both versions work fine with pm-utils. Enabling it
>> in busybox seems like simpliest solution for the problem.
> simplest
Thanks, fixed in v2.
>
>> Signed-off-by: Peter Tworek<tworaz666@gmail.com>
>> ---
>> meta/recipes-core/busybox/busybox-1.19.3/defconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-core/busybox/busybox-1.19.3/defconfig b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>> index b474ad4..fa9c078 100644
>> --- a/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>> +++ b/meta/recipes-core/busybox/busybox-1.19.3/defconfig
>> @@ -540,7 +540,7 @@ CONFIG_FEATURE_FDISK_WRITABLE=y
>> # CONFIG_FEATURE_GPT_LABEL is not set
>> # CONFIG_FEATURE_FDISK_ADVANCED is not set
>> # CONFIG_FINDFS is not set
>> -# CONFIG_FLOCK is not set
>> +CONFIG_FLOCK=y
>> # CONFIG_FREERAMDISK is not set
>> CONFIG_FSCK_MINIX=y
>> # CONFIG_MKFS_EXT2 is not set
> People are always interested in the size changes of the package when
> such programs are added to the default configuration. Do you have such
> numbers?
Added some data to v2. On armv5t it makes busybox binary larger by ~2.8k
>
> Reviewed-by: Paul Menzel<paulepanter@users.sourceforge.net>
>
>
> Thanks,
>
> Paul
next prev parent reply other threads:[~2012-02-04 0:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 20:21 [PATCH] busybox: Add flock utility to default configuration Peter Tworek
2012-02-03 17:46 ` Paul Menzel
2012-02-03 23:55 ` Peter Tworek [this message]
2012-02-08 4:02 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F2C73E3.2070708@gmail.com \
--to=tworaz666@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paulepanter@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox