Re: [PATCH 19/20] gcc-cross-testing: Fix evaluation of user and target name

[Saul Wold <sgw@linux.intel.com>]

On 02/05/2012 10:40 PM, Khem Raj wrote:
> Dont use -q to grep we pipe to /dev/null anyway all we
> care is the return status of grep
>
> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>
> xxx
>
> Signed-off-by: Khem Raj<raj.khem@gmail.com>

The patch seem valid, but the commit message needs to be cleaned up.


Sau!

> ---
>   meta/recipes-devtools/gcc/gcc-cross.inc |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-cross.inc b/meta/recipes-devtools/gcc/gcc-cross.inc
> index 6acf8c5..b16c57d 100644
> --- a/meta/recipes-devtools/gcc/gcc-cross.inc
> +++ b/meta/recipes-devtools/gcc/gcc-cross.inc
> @@ -65,11 +65,11 @@ then
>   	exit 1;
>   fi
>
> -echo "\$target" | grep −q "@">&  /dev/null
> +echo "\$target" | grep "@">&  /dev/null
>   if [ "x\$?" = "x0" ]
>   then
> -   user=echo \$target | cut -d '@' -f 1
> -   target=echo \$target | cut -d '@' -f 2
> +   user=\$(echo \$target | cut -d '@' -f 1)
> +   target=\$(echo \$target | cut -d '@' -f 2)
>   else
>      user=\$USER
>   fi