Re: [PATCH] dhcp: Update to 4.2.3-P2

[Mark Hatle <mark.hatle@windriver.com>]

On 2/8/12 11:10 AM, Phil Blundell wrote:
> On Wed, 2012-02-08 at 18:06 +0200, Andrei Gherzan wrote:
>> 1. Update to 4.2.3-P2
>> 2. From 4.2.0 final release, -lcrypto check was removed and we compile static libraries
>> from bind that are linked to libcrypto. This is why i added a patch in order to add
>> -lcrypto to LIBS.
>>
>> Signed-off-by: Andrei Gherzan<andrei@gherzan.ro>
>
> [...]
>
>> @@ -66,7 +61,7 @@ FILES_dhcp-server-config = "${sysconfdir}/default/dhcp-server ${sysconfdir}/dhcp
>>
>>   FILES_dhcp-relay = "${sbindir}/dhcrelay ${sysconfdir}/init.d/dhcp-relay ${sysconfdir}/default/dhcp-relay"
>>
>> -FILES_dhcp-client = "${base_sbindir}/dhclient ${base_sbindir}/dhclient-script ${sysconfdir}/dhcp/dhclient.conf"
>> +FILES_dhcp-client = "${sbindir}/dhclient ${base_sbindir}/dhclient-script ${sysconfdir}/dhcp/dhclient.conf"
>>   RDEPENDS_dhcp-client = "bash"
>>
>>   FILES_dhcp-omshell = "${bindir}/omshell"
>
> This isn't just a straightforward update, you seem to be moving dhclient
> from ${base_sbindir} to ${sbindir}.  If that's a good thing (which
> doesn't seem totally obvious to me) then it ought at least to be
> mentioned in the commit message.

I believe that dhcp-client was in the base_sbindir specifically to enable early 
boot/network setup before /usr is potentially available.  I think this is still 
desired.

--Mark

> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core