From: Andreas Oberritter <obi@opendreambox.org>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] autotools.bbclass: Don't copy into non-existant directory
Date: Sat, 11 Feb 2012 17:02:08 +0100 [thread overview]
Message-ID: <4F369100.6060502@opendreambox.org> (raw)
In-Reply-To: <20120211020749.GE2095@sakrah.homelinux.org>
On 11.02.2012 03:07, Khem Raj wrote:
> On (10/02/12 19:00), Andreas Oberritter wrote:
>> * If configure.ac contains AM_GNU_GETTEXT and po/Makefile.in.in
>> doesn't exist, autotools_do_configure() copies a local
>> version of Makefile.in.in to this location. If the directory
>> 'po' doesn't exist, the function aborts.
>>
>> * This patch verifies that the directory exists before copying
>> a file to it. This fixes libcddb, which uses AM_GNU_GETTEXT,
>> but has no 'po' directory.
>>
>
> this patch is ok however did you try to create the dir and then copy
> over the file if it did not exist ?
I didn't, because I don't think it would do anything useful, if there
are no other files in po/.
>> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
>> ---
>> meta/classes/autotools.bbclass | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
>> index 5d74333..e22ea68 100644
>> --- a/meta/classes/autotools.bbclass
>> +++ b/meta/classes/autotools.bbclass
>> @@ -149,7 +149,7 @@ autotools_do_configure() {
>> else if grep "^[[:space:]]*AM_GNU_GETTEXT" $CONFIGURE_AC >/dev/null; then
>> # We'd call gettextize here if it wasn't so broken...
>> cp ${STAGING_DATADIR}/gettext/config.rpath ${AUTOTOOLS_AUXDIR}/
>> - if [ ! -e ${S}/po/Makefile.in.in ]; then
>> + if [ -d ${S}/po/ -a ! -e ${S}/po/Makefile.in.in ]; then
>> cp ${STAGING_DATADIR}/gettext/po/Makefile.in.in ${S}/po/
>> fi
>> fi
>> --
>> 1.7.5.4
>>
>
>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
next prev parent reply other threads:[~2012-02-11 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 18:00 [PATCH] autotools.bbclass: Don't copy into non-existant directory Andreas Oberritter
2012-02-11 2:07 ` Khem Raj
2012-02-11 16:02 ` Andreas Oberritter [this message]
2012-02-24 18:29 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F369100.6060502@opendreambox.org \
--to=obi@opendreambox.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox