Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Andreas Oberritter <obi@opendreambox.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] consolekit: depend on libx11
Date: Sat, 11 Feb 2012 17:16:08 +0100	[thread overview]
Message-ID: <4F369448.2070900@opendreambox.org> (raw)
In-Reply-To: <20120211020917.GF2095@sakrah.homelinux.org>

On 11.02.2012 03:09, Khem Raj wrote:
> On (10/02/12 23:04), Andreas Oberritter wrote:
>> * Fixes the following error at configure time:
>>
>> |checking for TOOLS... no
>> |configure: error: Package requirements (x11 >= 1.0.0
>> |  glib-2.0 >= 2.14
>> |) were not met:
>> |
>> |No package 'x11' found
>>
>> Signed-off-by: Andreas Oberritter <obi@opendreambox.org>
>> ---
>> * Note that I didn't build test this, because I'm building
>>   without x11. I just looked up the package of x11.pc, which
>>   at least in Ubuntu is libx11.
>>
>>  .../recipes-support/consolekit/consolekit_0.4.5.bb |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> index 3ded6df..3a4b04f 100644
>> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
>> @@ -13,7 +13,7 @@ POLKIT_libc-uclibc = ""
>>  POLKITCONF = ""
>>  POLKITCONF_libc-uclibc = "--disable-policykit"
>>  
>> -DEPENDS = "glib-2.0 dbus ${POLKIT} ${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
>> +DEPENDS = "glib-2.0 dbus ${POLKIT} ${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)} virtual/libx11"
> 
> should this depend on if x11 is in DISTRO_FEATURES ?

If it was conditional, someone would have to fix consolekit first in
order to make it build without x11. This would be no problem for someone
interested in it, but it can still be done later.

>>  RDEPENDS_${PN} += "base-files"
>>  
>>  inherit gnome
>> -- 
>> 1.7.5.4
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 




  reply	other threads:[~2012-02-11 16:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 22:04 [PATCH] consolekit: depend on libx11 Andreas Oberritter
2012-02-11  2:09 ` Khem Raj
2012-02-11 16:16   ` Andreas Oberritter [this message]
2012-02-21 19:08 ` Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F369448.2070900@opendreambox.org \
    --to=obi@opendreambox.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox