From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com ([192.55.52.93]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1S0N9B-0007t1-Km for openembedded-core@lists.openembedded.org; Thu, 23 Feb 2012 02:07:01 +0100 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 22 Feb 2012 16:58:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="120313682" Received: from unknown (HELO [10.255.15.72]) ([10.255.15.72]) by fmsmga001.fm.intel.com with ESMTP; 22 Feb 2012 16:58:40 -0800 Message-ID: <4F458F3F.50409@linux.intel.com> Date: Wed, 22 Feb 2012 16:58:39 -0800 From: Saul Wold User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 MIME-Version: 1.0 To: Patches and discussions about the oe-core layer References: <1329519371-12600-1-git-send-email-obi@opendreambox.org> In-Reply-To: <1329519371-12600-1-git-send-email-obi@opendreambox.org> Subject: Re: [PATCH 1/2] gst-plugins-base: depend on libx11 and libxv conditionally X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Feb 2012 01:07:01 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 02/17/2012 02:56 PM, Andreas Oberritter wrote: > * gst-plugins-base currently doesn't build if x11 is > unavailable, due to unconditional dependencies on libx11 > and libxv. However, they are not required to build > gst-plugins-base. > > Signed-off-by: Andreas Oberritter > --- > .../gstreamer/gst-plugins-base_0.10.35.bb | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.35.bb b/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.35.bb > index e49a00c..0b287bc 100644 > --- a/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.35.bb > +++ b/meta/recipes-multimedia/gstreamer/gst-plugins-base_0.10.35.bb > @@ -6,7 +6,8 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \ > file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605 \ > file://gst/ffmpegcolorspace/utils.c;beginline=1;endline=20;md5=9c83a200b8e597b26ca29df20fc6ecd0" > > -DEPENDS += "virtual/libx11 alsa-lib freetype liboil libogg libvorbis libxv libtheora avahi util-linux tremor" > +DEPENDS += "${@base_contains('DISTRO_FEATURES', 'x11', 'virtual/libx11 libxv', '', d)}" > +DEPENDS += "alsa-lib freetype liboil libogg libvorbis libtheora avahi util-linux tremor" > > SRC_URI += " file://gst-plugins-base-tremor.patch" > As with the other patches do you need to have some configure option to ensure that these will be exculded if perhaps the build already contains these libraries? This also pertains to your mpeg2dev patch Sau!