Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/4] default-distrovars: Add empty weak definition for DISTRO variable
Date: Mon, 05 Mar 2012 13:36:05 -0800	[thread overview]
Message-ID: <4F5531C5.30007@linux.intel.com> (raw)
In-Reply-To: <CAMKF1srNpxainQ2ZyZ=wKZmmuLdp_fEjyTr1JKMRGVO4X8QV2w@mail.gmail.com>

On 02/24/2012 09:05 AM, Khem Raj wrote:
> On Fri, Feb 24, 2012 at 8:21 AM, Richard Purdie
> <richard.purdie@linuxfoundation.org>  wrote:
>> On Thu, 2012-02-23 at 19:33 -0800, Khem Raj wrote:
>>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>> ---
>>>   meta/conf/distro/include/default-distrovars.inc |    7 +++++++
>>>   1 files changed, 7 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc
>>> index 16b3108..dba204e 100644
>>> --- a/meta/conf/distro/include/default-distrovars.inc
>>> +++ b/meta/conf/distro/include/default-distrovars.inc
>>> @@ -41,6 +41,13 @@ NO32LIBS ??= "1"
>>>
>>>   # Default to emitting logfiles if a build fails.
>>>   BBINCLUDELOGS ??= "yes"
>>> +
>>> +# dummy distro related variables
>>> +# they should be overridden by real distros
>>> +# these fallbacks only serve the purpose of
>>> +# oe-core standalone testability
>>> +
>>> +DISTRO ??= ""
>>>   SDK_VERSION ??= "oe-core.0"
>>>   DISTRO_VERSION ??= "oe-core.0"
>>
>> Why do we need this? The commit message tells me what you're doing but
>> not why. I'm really getting frustrated with one line commit messages
>> with no details.
>>
>> I don't think we should need this either, I'm not sure I like the
>> change. The whole idea was OE-Core could run "distroless".
>>
>
> There is an error case I dont remeber how I obtained that where it
> prints bogus value if DISTRO is not
> defined at all but and empty DISTRO var is distroless in essence anyway IMO
>
Khem,

Please let us know what the reproducer for this is.  Once we have a 
reproducer we can look into the issue.

Sau!

>> Cheers,
>>
>> Richard
>>
>>
>>
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core



  reply	other threads:[~2012-03-05 21:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-24  3:33 [PATCH 0/4] stash gcc-cross buildtree and add recipe class override Khem Raj
2012-02-24  3:33 ` [PATCH 1/4] glib-networking: Add intltools-native to DEPENDS Khem Raj
2012-02-24  3:33 ` [PATCH 2/4] classes: Add recipe class to overrides Khem Raj
2012-02-24 16:20   ` Richard Purdie
2012-02-24 17:02     ` Khem Raj
2012-02-24  3:33 ` [PATCH 3/4] default-distrovars: Add empty weak definition for DISTRO variable Khem Raj
2012-02-24 16:21   ` Richard Purdie
2012-02-24 17:05     ` Khem Raj
2012-03-05 21:36       ` Saul Wold [this message]
2012-03-05 23:02         ` Khem Raj
2012-03-22  1:23         ` Denys Dmytriyenko
2012-03-22  4:22           ` Khem Raj
2012-03-22 16:48             ` Khem Raj
2012-03-22 17:52               ` Richard Purdie
2012-02-24  3:33 ` [PATCH 4/4] gcc: Stash the gcc-cross builddir to reuse in libgcc and gcc-runtime Khem Raj
2012-02-27 19:57 ` [PATCH 0/4] stash gcc-cross buildtree and add recipe class override Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5531C5.30007@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox